Skip to content

Commit

Permalink
filter-repo: fix some unfortunate local variable names
Browse files Browse the repository at this point in the history
Referring to hashes with the names of new_id and orig_id are horribly
misleading since everywhere else "id" means fast export ids, i.e.
integers.  Rename these local variables to new_hash and orig_hash.

Signed-off-by: Elijah Newren <[email protected]>
  • Loading branch information
newren committed Oct 21, 2024
1 parent 4fda88e commit 8bd8803
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions git-filter-repo
Original file line number Diff line number Diff line change
Expand Up @@ -3153,10 +3153,10 @@ class RepoFilter(object):
return
fi_input, fi_output = self._import_pipes
while self._pending_renames:
orig_id, ignore = self._pending_renames.popitem(last=False)
new_id = fi_output.readline().rstrip()
self._commit_renames[orig_id] = new_id
if old_hash == orig_id:
orig_hash, ignore = self._pending_renames.popitem(last=False)
new_hash = fi_output.readline().rstrip()
self._commit_renames[orig_hash] = new_hash
if old_hash == orig_hash:
return
if limit and len(self._pending_renames) < limit:
return
Expand Down

0 comments on commit 8bd8803

Please sign in to comment.