Code

Maximize code coverage in test suite#914

Code

Draft

gonzaponte wants to merge 132 commits intonext-exp:masternext-exp/IC:masterfrom gonzaponte:coveragegonzaponte/IC:coverageCopy head branch name to clipboard

+1,318-840

Commits

Commits on Nov 19, 2024

• Add coverage report to GHA

  gonzaponte

  committed
  e07e229

  Copy full SHA for e07e229

• Remove unnecessary checks

  Show description for 5741c7e
  gonzaponte

  committed
  5741c7e

  Copy full SHA for 5741c7e

• Check annotations in create_deconvolution_df

  gonzaponte

  committed
  8ef6771

  Copy full SHA for 8ef6771

• Test that beersheba checks dimensions

  gonzaponte

  committed
  8e68dab

  Copy full SHA for 8e68dab

• Parametrize sophronia test to run with and without corrections

  gonzaponte

  committed
  ce0658a

  Copy full SHA for ce0658a

• Remove deprecated out_of_map variable

  gonzaponte

  committed
  9263078

  Copy full SHA for 9263078

• Add tests to check behaviour of reconstruction failures

  gonzaponte

  committed
  f0784da

  Copy full SHA for f0784da

• Remove unused calibrate components

  gonzaponte

  committed
  c613d58

  Copy full SHA for c613d58

• Check annotations in sensor_data

  gonzaponte

  committed
  aea7070

  Copy full SHA for aea7070

• Do not ignore missing tables in MC_hits_from_files

  gonzaponte

  committed
  1f49d6c

  Copy full SHA for 1f49d6c

• Add test to verify that eutropia doesn't complain about bad files

  gonzaponte

  committed
  9a51608

  Copy full SHA for 9a51608

• Remove unnecessary protections

  Show description for 72ec7d2
  gonzaponte

  committed
  72ec7d2

  Copy full SHA for 72ec7d2

• Test length of failing case

  gonzaponte

  committed
  c392953

  Copy full SHA for c392953

• Check annotations in get_{pmt,sipm}_wfs

  gonzaponte

  committed
  43ebead

  Copy full SHA for 43ebead

• Make get_run_number more robust and test it

  gonzaponte

  committed
  48703d9

  Copy full SHA for 48703d9

• Fix type hint

  gonzaponte

  committed
  83cc57a

  Copy full SHA for 83cc57a

• Mark test as xfailed

  gonzaponte

  committed
  c02d4aa

  Copy full SHA for c02d4aa

• Delete deprecated test

  Show description for c88cb0d
  gonzaponte

  committed
  c88cb0d

  Copy full SHA for c88cb0d

• Protect against empty input pmap file

  gonzaponte

  committed
  56f5889

  Copy full SHA for 56f5889

• Protect against empty input dst file

  gonzaponte

  committed
  17ba2b5

  Copy full SHA for 17ba2b5

• Expand dorothea test to catch warning

  gonzaponte

  committed
  8d10e41

  Copy full SHA for 8d10e41

• Add protection against empty output

  gonzaponte

  committed
  b6460fa

  Copy full SHA for b6460fa

• Extend test to catch warning

  gonzaponte

  committed
  9763ff2

  Copy full SHA for 9763ff2

• Fix test_pmap_event_id_selection

  gonzaponte

  committed
  452a6ec

  Copy full SHA for 452a6ec

• Rewrite peak selection tests

  gonzaponte

  committed
  532528f

  Copy full SHA for 532528f

• Move width calculation to fixture

  gonzaponte

  committed
  f0a7a53

  Copy full SHA for f0a7a53

• Add test_voxels_within_radius and test_energy_of_voxels_within_radius

  gonzaponte

  committed
  5337827

  Copy full SHA for 5337827

• Add test_load_dst_warns_corrupted_file

  gonzaponte

  committed
  79ea67d

  Copy full SHA for 79ea67d

• Exclude celsius from coverage report

  gonzaponte

  committed
  4170697

  Copy full SHA for 4170697

• Remove unreachable if/else branch

  gonzaponte

  committed
  12bc722

  Copy full SHA for 12bc722

• Remove unused fixture

  gonzaponte

  committed
  bbfa1a2

  Copy full SHA for bbfa1a2

• Parametrize test_create_deconvolution_df to use both values of CutType

  gonzaponte

  committed
  793775b

  Copy full SHA for 793775b

• Add test_beersheba_ndim

  gonzaponte

  committed
  755dfca

  Copy full SHA for 755dfca

• Remove unused function

  gonzaponte

  committed
  82797e5

  Copy full SHA for 82797e5

• Add test_merge_nn_hits_different_peaks

  gonzaponte

  committed
  323aa73

  Copy full SHA for 323aa73

• Rewrite test_drop_isolated_sensors

  gonzaponte

  committed
  f1e30b0

  Copy full SHA for f1e30b0

• Add test_read_maps_data_without_time_evolution

  gonzaponte

  committed
  82757cc

  Copy full SHA for 82757cc

• Exclude line from coverage report

  Show description for 3608069
  gonzaponte

  committed
  3608069

  Copy full SHA for 3608069

• Add test_get_lt_values_complains_if_input_mismatch

  gonzaponte

  committed
  609fda5

  Copy full SHA for 609fda5

• Add tests for pad_safe

  gonzaponte

  committed
  0c363ff

  Copy full SHA for 0c363ff

• Replace useless statement with pass

  gonzaponte

  committed
  0ce0a33

  Copy full SHA for 0ce0a33

• Exclude test from coverage report

  gonzaponte

  committed
  4299dee

  Copy full SHA for 4299dee

• Remove unnecessary check

  gonzaponte

  committed
  6819f9e

  Copy full SHA for 6819f9e

• Add tests for diomira's select_trigger_filter and emulate_trigger

  gonzaponte

  committed
  ef0aa5a

  Copy full SHA for ef0aa5a

• Exclude function from coverage report

  gonzaponte

  committed
  4a6ba65

  Copy full SHA for 4a6ba65

• Add tests for get_actual_sipm_thr

  gonzaponte

  committed
  a091bd6

  Copy full SHA for a091bd6

• Add and check annotations in get_actual_sipm_threshold

  gonzaponte

  committed
  001e365

  Copy full SHA for 001e365

• Add test_copy_mc_info_raises_missing_event

  gonzaponte

  committed
  a007b30

  Copy full SHA for a007b30

• Add tests for dst_from_files

  gonzaponte

  committed
  d02d442

  Copy full SHA for d02d442

• Add warning for empty input in dhits_from_files

  gonzaponte

  committed
  6ee4a27

  Copy full SHA for 6ee4a27

• Add test for dhits_from_files

  gonzaponte

  committed
  d656fc6

  Copy full SHA for d656fc6

• Replace meaningless checks with TODOs

  gonzaponte

  committed
  789d07f

  Copy full SHA for 789d07f

• Comment out unused fixture

  Show description for 73a8f6c
  gonzaponte

  committed
  73a8f6c

  Copy full SHA for 73a8f6c

• Simplify test_dropped_voxels_have_nan_energy

  gonzaponte

  committed
  3935448

  Copy full SHA for 3935448

• Drop unused function

  gonzaponte

  committed
  767ce5d

  Copy full SHA for 767ce5d

• Remove unused composite

  gonzaponte

  committed
  b40b1fa

  Copy full SHA for b40b1fa

• Use environment variable in config file

  Show description for da04fe6
  gonzaponte

  committed
  da04fe6

  Copy full SHA for da04fe6

• Exclude empty lines from coverage report

  gonzaponte

  committed
  02369e0

  Copy full SHA for 02369e0

• Fix test_incorrect_sensor_type_raises_ValueError

  Show description for 34dd282
  gonzaponte

  committed
  34dd282

  Copy full SHA for 34dd282

• Remove unnecessary try/except clauses

  Show description for 4a29908
  gonzaponte

  committed
  4a29908

  Copy full SHA for 4a29908

• Exclude function from coverage report

  gonzaponte

  committed
  093194c

  Copy full SHA for 093194c

• Add tests for noise_suppression

  gonzaponte

  committed
  e1ea9b9

  Copy full SHA for e1ea9b9

• Protect against non-existing DBs

  gonzaponte

  committed
  608081d

  Copy full SHA for 608081d

• Fix test_RadioactivityData_get_version

  gonzaponte

  committed
  3735a32

  Copy full SHA for 3735a32

• Remove unnecessary else branch

  gonzaponte

  committed
  c3c54b6

  Copy full SHA for c3c54b6

• Remove old MC checks from coverage report

  gonzaponte

  committed
  a13b4ea

  Copy full SHA for a13b4ea

• Exclude specific lines from coverage report

  gonzaponte

  committed
  0f23fa2

  Copy full SHA for 0f23fa2

• Extend test to include another invalid input

  gonzaponte

  committed
  b4359cc

  Copy full SHA for b4359cc

• Add tests for seeds_and_bounds_with_db

  gonzaponte

  committed
  c432a4c

  Copy full SHA for c432a4c

• Add tests for sensor type input

  gonzaponte

  committed
  6179896

  Copy full SHA for 6179896

• Exclude likely-to-be-deprecated function from coverage report

  gonzaponte

  committed
  fef2203

  Copy full SHA for fef2203

• Add tests for S12SelectorOutput

  gonzaponte

  committed
  5895ca3

  Copy full SHA for 5895ca3

• Improve tests for fixed_parameters

  gonzaponte

  committed
  ef4a3e6

  Copy full SHA for ef4a3e6

• Add test_get_chi2_and_pvalue_auto_errors

  gonzaponte

  committed
  8c88827

  Copy full SHA for 8c88827

• Parametrize test_profileXY

  gonzaponte

  committed
  45244ce

  Copy full SHA for 45244ce

• Add test_drop_isolated_sensors_drop_all

  gonzaponte

  committed
  9b7fba9

  Copy full SHA for 9b7fba9

• Exclude line from coverage report

  gonzaponte

  committed
  806ee8e

  Copy full SHA for 806ee8e

• Test convergence in lucy_richardson

  gonzaponte

  committed
  a07a26d

  Copy full SHA for a07a26d

• Add tests for tbl.filters

  gonzaponte

  committed
  e5369bb

  Copy full SHA for e5369bb

• Replace useless dbnew fixture

  gonzaponte

  committed
  bea0544

  Copy full SHA for bea0544

• Remove unused fixtures and files

  gonzaponte

  committed
  899e358

  Copy full SHA for 899e358

• Remove block from coverage report

  gonzaponte

  committed
  35a6bbd

  Copy full SHA for 35a6bbd

• Remove functions from coverage report

  gonzaponte

  committed
  7ca8af7

  Copy full SHA for 7ca8af7

• Add more tests to dataflow

  gonzaponte

  committed
  c43c652

  Copy full SHA for c43c652

• Exclude block from coverage report

  gonzaponte

  committed
  6a57bca

  Copy full SHA for 6a57bca

• Remove unused function

  gonzaponte

  committed
  5c1cccb

  Copy full SHA for 5c1cccb

• Exclude function from coverage report

  gonzaponte

  committed
  f4de34c

  Copy full SHA for f4de34c

• Remove unused function

  gonzaponte

  committed
  880aed4

  Copy full SHA for 880aed4

• Cosmetics

  Show description for 32dd67a
  gonzaponte

  committed
  32dd67a

  Copy full SHA for 32dd67a

• Exclude skipped tests from coverage report

  gonzaponte

  committed
  57cc171

  Copy full SHA for 57cc171

• Exclude functions from coverage report

  Show description for 3729342
  gonzaponte

  committed
  3729342

  Copy full SHA for 3729342

• Extend tests for xy

  gonzaponte

  committed
  04370a5

  Copy full SHA for 04370a5

• Add test for minmax equality

  gonzaponte

  committed
  9a49f03

  Copy full SHA for 9a49f03

• Add tests for event_range

  gonzaponte

  committed
  9499556

  Copy full SHA for 9499556

• Exclude line from coverage report

  gonzaponte

  committed
  021d962

  Copy full SHA for 021d962

• Add test for compare_signature_to_values

  gonzaponte

  committed
  41bb9da

  Copy full SHA for 41bb9da

• Exclude method from coverage report

  gonzaponte

  committed
  3e5f067

  Copy full SHA for 3e5f067

• Exclude very slow test from coverage report

  gonzaponte

  committed
  11875d4

  Copy full SHA for 11875d4

• Exlude skipped test from coverage report

  gonzaponte

  committed
  ed3ad98

  Copy full SHA for ed3ad98

• Exclude exception handling from coverage report

  Show description for f68d43f
  gonzaponte

  committed
  f68d43f

  Copy full SHA for f68d43f

• Drop unused function

  gonzaponte

  committed
  da45db7

  Copy full SHA for da45db7

• Delete unused TrackCollection

  gonzaponte

  committed
  08aa2f0

  Copy full SHA for 08aa2f0

• Add test for KrEvent's fill_defaults

  gonzaponte

  committed
  7957c2f

  Copy full SHA for 7957c2f

• Fix KrEvent's fill_defaults

  gonzaponte

  committed
  676efa1

  Copy full SHA for 676efa1

• Remove unused function/file

  gonzaponte

  committed
  2eb5943

  Copy full SHA for 2eb5943

• Replace exit with raise

  gonzaponte

  committed
  1b9531a

  Copy full SHA for 1b9531a

• Refactor channel_param_io tests

  gonzaponte

  committed
  8cb36f7

  Copy full SHA for 8cb36f7

• Refactor channel_param_io module

  gonzaponte

  committed
  3c18fc1

  Copy full SHA for 3c18fc1

• Add more tests

  gonzaponte

  committed
  82178db

  Copy full SHA for 82178db

• Replace skip mark with xfail mark

  gonzaponte

  committed
  41764d3

  Copy full SHA for 41764d3

• Fix download db test

  gonzaponte

  committed
  138accb

  Copy full SHA for 138accb

• Remove pytest decorator in non-test function

  gonzaponte

  committed
  aa2a45f

  Copy full SHA for aa2a45f

• Exclude database folder from coverage report

  gonzaponte

  committed
  0e3ea38

  Copy full SHA for 0e3ea38

• Mark some tests as slow

  gonzaponte

  committed
  383e59f

  Copy full SHA for 383e59f

• Fix typo

  gonzaponte

  committed
  fe99896

  Copy full SHA for fe99896

• Refactor peak selection tests

  gonzaponte

  committed
  6ebe93a

  Copy full SHA for 6ebe93a

• Cosmetics

  gonzaponte

  committed
  45ad871

  Copy full SHA for 45ad871

• Extend testing for copy_cities_configuration

  gonzaponte

  committed
  60ce2dd

  Copy full SHA for 60ce2dd

• Remove unnecessary check

  gonzaponte

  committed
  81b743c

  Copy full SHA for 81b743c

• Remove unused classes

  gonzaponte

  committed
  41d2943

  Copy full SHA for 41d2943

• Exlude block from coverage report

  gonzaponte

  committed
  11be238

  Copy full SHA for 11be238

• Fix test name

  Show description for 74d0040
  gonzaponte

  committed
  74d0040

  Copy full SHA for 74d0040

• Refactor light_tables_c_test

  Show description for bea031b
  gonzaponte

  committed
  bea031b

  Copy full SHA for bea031b

• Exclude line from coverage report

  Show description for e81adba
  gonzaponte

  committed
  e81adba

  Copy full SHA for e81adba

• Refactor test to avoid subcases

  gonzaponte

  committed
  46ad5b5

  Copy full SHA for 46ad5b5

• Split test_rebin_peak_threshold test into many

  gonzaponte

  committed
  6bd8791

  Copy full SHA for 6bd8791

• Rename test

  gonzaponte

  committed
  dde37fb

  Copy full SHA for dde37fb

Commits on Nov 21, 2024

• Refactor test to avoid skipping if branch

  gonzaponte

  committed
  4d085b8

  Copy full SHA for 4d085b8

• Extract coverage report into its own workflow

  Show description for 04f6672
  gonzaponte

  committed
  04f6672

  Copy full SHA for 04f6672

• Raise a warning if coverage incomplete

  gonzaponte

  committed
  9a12f2f

  Copy full SHA for 9a12f2f

• Silence warning in regarding no pmaps in input

  gonzaponte

  committed
  7b61b82

  Copy full SHA for 7b61b82

• Silence warning

  gonzaponte

  committed
  835e770

  Copy full SHA for 835e770