Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸš€ 4단계 - μžλ™μ°¨ κ²½μ£Ό(우승자) - μ½”λ“œλ¦¬λ·°λ₯Ό λ°”νƒ•μœΌλ‘œ μˆ˜μ • #5807

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

πŸš€ 4단계 - μžλ™μ°¨ κ²½μ£Ό(우승자) - μ½”λ“œλ¦¬λ·°λ₯Ό λ°”νƒ•μœΌλ‘œ μˆ˜μ • #5807

wants to merge 14 commits into from

Conversation

yunji1201
Copy link

No description provided.

@yunji1201
Step1 (next-step#5615)
bb020a6 
* test : "1,2"을 ,둜 split ν–ˆμ„ λ•Œ 1κ³Ό 2둜 잘 λΆ„λ¦¬λ˜λŠ”μ§€ ν…ŒμŠ€νŠΈ

* refactor : λ©”μ†Œλ“œλͺ… λ³€κ²½ split() -> splitTwoNum()

* test : "1"을 ,둜 split ν–ˆμ„ λ•Œ 1λ§Œμ„ ν¬ν•¨ν•˜λŠ” 배열이 λ°˜ν™˜λ˜λŠ”μ§€ ν…ŒμŠ€νŠΈ

* test : "(1,2)" κ°’μ—μ„œ substring() λ©”μ†Œλ“œλ₯Ό ν™œμš©ν•΄ ()을 μ œκ±°ν•˜κ³  "1,2"λ₯Ό λ°˜ν™˜ν•˜λŠ” ν…ŒμŠ€νŠΈ

* test : charAt() λ©”μ†Œλ“œλ‘œ νŠΉμ • μœ„μΉ˜μ˜ 문자 κ°€μ Έμ˜€λŠ” ν…ŒμŠ€νŠΈ

* test : μœ„μΉ˜ κ°’ 벗어났을 λ–„μ˜ StringIndexOutOfBoundsException λ°œμƒ ν…ŒμŠ€νŠΈ

* test : @DisplayName μ‚¬μš©ν•˜μ—¬ 가독성 ν–₯상

* test : @beforeeach둜 ν…ŒμŠ€νŠΈ λ©”μ„œλ“œκ°€ μ‹€ν–‰λ˜κΈ° 전에 맀번 μ‹€ν–‰λ˜λŠ” λ©”μ„œλ“œ μ •μ˜

* test : size() λ©”μ†Œλ“œλ₯Ό 톡해 Set의 크기λ₯Ό ν™•μΈν•˜λŠ” ν…ŒμŠ€νŠΈ

* test : Set의 contains() λ©”μ†Œλ“œλ₯Ό ν™œμš©ν•΄ 1, 2, 3의 값이 μ‘΄μž¬ν•˜λŠ”μ§€λ₯Ό 확인 ν…ŒμŠ€νŠΈ

* test : @ParameterizedTest @valuesource ν™œμš©ν•΄ 쀑볡 μ½”λ“œ 제거

* test : @CsvSource ν™œμš©ν•˜μ—¬ true/false 검증을 μœ„ν•œ νŒŒλΌλ―Έν„°ν™” ν…ŒμŠ€νŠΈ
@yunji1201
2단계 - λ¬Έμžμ—΄ λ§μ…ˆ 계산기 (next-step#5715)
cdfb759 
* refactor : μ½”λ“œλ¦¬λ·° μ½”λ©˜νŠΈ 받은 λΆ€λΆ„ μˆ˜μ •

* test : 숫자 ν•˜λ‚˜λ₯Ό λ¬Έμžμ—΄λ‘œ μž…λ ₯ν•  μ‹œ ν•΄λ‹Ή 숫자λ₯Ό λ°˜ν™˜ν•˜λŠ”μ§€ ν…ŒμŠ€νŠΈ

* test : μ‰Όν‘œ λ˜λŠ” μ½œλ‘ μ„ κ΅¬λΆ„μžλ‘œ κ°€μ§€λŠ” λ¬Έμžμ—΄μ„ 전달할 경우 κ΅¬λΆ„μžλ₯Ό κΈ°μ€€μœΌλ‘œ λΆ„λ¦¬ν•œ 각 숫자의 합을 λ°˜ν™˜ν•˜λŠ”μ§€ ν…ŒμŠ€νŠΈ

* test : 빈 λ¬Έμžμ—΄ λ˜λŠ” null 값을 μž…λ ₯ν•  경우 0을 λ°˜ν™˜ν•˜λŠ” ν…ŒμŠ€νŠΈ

* refactor : 같은 ν•¨μˆ˜ μ•ˆμ—μ„œ 좔상화 레벨 λ§žμΆ”λŠ” λ¦¬νŒ©ν† λ§

* test : //”와 β€œ\\n” 문자 사이에 놓인 문자λ₯Ό μ»€μŠ€ν…€ κ΅¬λΆ„μžλ‘œ μ§€μ •ν•˜μ—¬ μ‚¬μš©ν•  수 μžˆλŠ”μ§€ ν™•μΈν•˜λŠ” ν…ŒμŠ€νŠΈ

* test : 숫자 μ΄μ™Έμ˜ κ°’ λ˜λŠ” 음수λ₯Ό 전달할 경우 RuntimeException μ˜ˆμ™Έλ₯Ό λ˜μ§€λŠ”μ§€ ν™•μΈν•˜λŠ” ν…ŒμŠ€νŠΈ

* refactor : μ΄λ¦„μœΌλ‘œ μ–΄λ–€ 역할을 ν•˜λŠ”μ§€ μ•Œ 수 μžˆλ„λ‘ λͺ…ν™•ν•œ μ΄λ¦„μœΌλ‘œ λ©”μ†Œλ“œλͺ… μˆ˜μ •

* remove : λΆˆν•„μš”ν•œ 클래슀 μ‚­μ œ

* refactor : 클래슀 레벨 μƒμˆ˜λ‘œ λ§Œλ“€μ–΄ Pattern μΈμŠ€ν„΄μŠ€λ₯Ό ν•œ 번만 μƒμ„±ν•˜κ³  μž¬ν™œμš©ν•  수 μžˆλ„λ‘ λ³€κ²½

* test : 숫자 μ΄μ™Έμ˜ 값을 전달할 경우 RuntimeException μ˜ˆμ™Έλ₯Ό λ˜μ§€λŠ”μ§€ ν™•μΈν•˜λŠ” ν…ŒμŠ€νŠΈ

* test : null 값을 전달할 경우 0을 λ°˜ν™˜ν•˜λŠ”μ§€ @NullAndEmptySource을 μ‚¬μš©ν•˜μ—¬ 확인 ν…ŒμŠ€νŠΈ

* add : 일뢀 μ‹œμŠ€ν…œμ—μ„œ λ§ˆμ§€λ§‰ 쀄이 μ •μƒμ μœΌλ‘œ μ½νžˆμ§€ μ•Šμ„ 경우λ₯Ό λ°©μ§€ν•˜κΈ° μœ„ν•΄ κ°œν–‰ μΆ”κ°€
@yunji1201
3단계 - μžλ™μ°¨ κ²½μ£Ό (next-step#5736)
e06edf2 
* docs : κΈ°λŠ₯ 뢄석 ν›„ todo.md μ—…λ°μ΄νŠΈ

* test : 0μ—μ„œ 9 μ‚¬μ΄μ—μ„œ 값이 4 이상일 κ²½μš°μ—λ§Œ μ „μ§„ν•˜κ³  4 μ΄ν•˜μΌ 경우 λ©ˆμΆ°μžˆλŠ”μ§€ ν™•μΈν•˜λŠ” ν…ŒμŠ€νŠΈ

* feat : μ‚¬μš©μžκ°€ μžλ™μž 수, 이동 수λ₯Ό μž…λ ₯ ν•  수 μžˆμ–΄μ•Ό 함

* test : 0μ—μ„œ 9 μ‚¬μ΄μ—μ„œ random 값을 κ΅¬ν•œ ν›„ random 값이 4이상일 κ²½μš°μ—λ§Œ μ „μ§„ν•˜λŠ” ν…ŒμŠ€νŠΈ

* feat : μžλ™μ°¨κ°€ μ‚¬μš©μžκ°€ μž…λ ₯ν•œ 값에 따라 κ²½κΈ°λ₯Ό μ§„ν–‰ν•˜κ³  움직이도둝 κΈ°λŠ₯ μΆ”κ°€

* feat : μžλ™μ°¨μ˜ μƒνƒœλ₯Ό 화면에 좜λ ₯

* refactor : μ€‘λ³΅λœ λ‚΄μš©μ˜ ν…ŒμŠ€νŠΈ λ©”μ†Œλ“œ 제거

* refactor : μΆ•μ•½λœ λ©”μ†Œλ“œλͺ…, λ³€μˆ˜λͺ… λͺ…ν™•ν•œ 의미λ₯Ό 갖도둝 μˆ˜μ •

* refactor : private μƒμ„±μžλ‘œ λΆˆν•„μš”ν•œ μΈμŠ€ν„΄μŠ€ν™” 막기

* refactor : forλ¬Έ -> repeat ν•¨μˆ˜ μ‚¬μš©

* refactor : 첫번째 λΌμš΄λ“œμ—μ„œ μžλ™μ°¨κ°€ λ°˜λ“œμ‹œ μ „μ§„ν•˜μ§€ μ•Šμ•„λ„ λ˜λ„λ‘ μ½”λ“œ μˆ˜μ •

* refactor : λ ˆμ΄μ‹± λΌμš΄λ“œ μ‹œμž‘ ν‘œμ‹œ μ½˜μ†”μ„ VIEWμ—μ„œ ν•˜λ„λ‘ μˆ˜μ •

* refactor : λΉ„μ¦ˆλ‹ˆμŠ€ 둜직과 UI λ‘œμ§μ„ λΆ„λ¦¬ν•˜κΈ° μœ„ν•˜μ—¬ μ˜μ‘΄μ„± μ£Όμž…μ„ μ‚¬μš©ν•œλ‹€
@yunji1201
refactor : μ½”λ“œλ¦¬λ·°λ₯Ό λ°”νƒ•μœΌλ‘œ λ¦¬νŒ©ν† λ§ μž‘μ—…
3945b00
@yunji1201
refactor : 도메인(Racing)이 view(ResultView)에 μ˜μ‘΄ν•˜μ§€ μ•Šλ„λ‘ ꡬ쑰 λ³€κ²½
0dc8a6b
@yunji1201
docs : 4단계 κΈ°λŠ₯ μš”κ΅¬μ‚¬ν•­ 정리
d80b43b
@yunji1201
test : μžλ™μ°¨ 이름이 5κΈ€μž 이상인 경우 μ—λŸ¬λ₯Ό λ°˜ν™˜ν•˜λŠ”μ§€ ν™•μΈν•˜λŠ” ν…ŒμŠ€νŠΈ
ea596ee
@yunji1201
feat : μ‚¬μš©μžκ°€ μžλ™μ°¨μ˜ 이름을 μž…λ ₯ ν•  수 μžˆμ–΄μ•Ό 함
29fff60
@yunji1201
feat : μ „μ§„ν•˜λŠ” μžλ™μ°¨λ₯Ό 좜λ ₯ν•  λ•Œ 이름을 같이 좜λ ₯
badbbec
@yunji1201
test : κ°€μž₯ λ§Žμ€ 거리λ₯Ό κ°„ μžλ™μ°¨λ₯Ό 우승자둜 λ°˜ν™˜ν•˜λŠ”μ§€ ν™•μΈν•˜λŠ” ν…ŒμŠ€νŠΈ 진행
d986739
@yunji1201
feat : λ ˆμ΄μ‹± μ™„λ£Œ ν›„ 우승자λ₯Ό 좜λ ₯ν•˜λŠ” κΈ°λŠ₯ μΆ”κ°€
0e5005e
@yunji1201
test : Racing ν΄λž˜μŠ€μ— λŒ€ν•œ ν…ŒμŠ€νŠΈ μΆ”κ°€
13a7434
@yunji1201
refactor : 각 도메인에 맞게 ν…ŒμŠ€νŠΈ 뢄리
f181330
@yunji1201
refactor : μ½”λ“œλ¦¬λ·° 받은걸 λ°”νƒ•μœΌλ‘œ λ¦¬νŒ©ν† λ§ 진행
68499a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yunji1201