Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step 5 - 자동차경주(리팩토링) #5815

Open
wants to merge 14 commits into
base: sparcsjara
Choose a base branch
from
Open

Step 5 - 자동차경주(리팩토링) #5815

wants to merge 14 commits into from

Commits on Oct 11, 2024

  1. refactor view: 패키지명 변경 ui->view 

    출입력 받는 패키지명을 ui->view로 변경
    @sparcsJara
    sparcsJara committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7979eeb View commit details
    Browse the repository at this point in the history

  2. refactor CarRacing.java, RacingFleet.java: 플릿에 속하는 자동차들 경주하는 함수를 raci… 

    …ngFleet으로 옮김

racingFleet에 속하는 차들 race하는 raceAll()함수를 만듬
    @sparcsJara
    sparcsJara committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    cb61665 View commit details
    Browse the repository at this point in the history

  3. refactor RacingCarStatesDTO.java: valueOf 인자를 racingFleet으로 변경 

    racingFleet에서 getRacingCars로 받고 있어서, RacingFleet로 인자로 받도록 변경
    @sparcsJara
    sparcsJara committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    3b86c47 View commit details
    Browse the repository at this point in the history

  4. refactor RacingFleet::raceAll: movableStrategy를 인자로 받게 함. 

    movableStrategy 결정자를 책임자인 carRacing으로 이동
    @sparcsJara
    sparcsJara committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e84f9f9 View commit details
    Browse the repository at this point in the history

  5. refactor RacingFleet::raceAll: movableStrategy를 인자로 받게 함. 

    movableStrategy 결정자를 책임자인 carRacing으로 이동
    @sparcsJara
    sparcsJara committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a1cc5e1 View commit details
    Browse the repository at this point in the history

  6. test RacingFleet::raceAll: raceAll 테스트 구현 

    raceAll 테스트 구현
    @sparcsJara
    sparcsJara committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    473befd View commit details
    Browse the repository at this point in the history

  7. fix RacingCarStatesDTO: carStates 필드 private로 변경 

    public으로 필드 접근 가능해서 private으로 변경
    @sparcsJara
    sparcsJara committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    8e9473b View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. refactor CarRacing.java, RacingHistories.java, RacingHistory.java: wr… 

    …apResults 필드를 histories로 변경

wrapResults를 DTO 필드가 아니라 Racinghistory를 나타내는 새로운 클래스를 만들어서 CarRacing에 저장함. 레이싱 결과 기록 관련 책임을 분리하여 응집도를 올림.
    @sparcsJara
    sparcsJara committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    edd4f72 View commit details
    Browse the repository at this point in the history

  2. test RacingHistoriesTest: RacingHistories에 대한 테스트 작성 

    RacingFleet를 통해 RacingState를 저장하는 함수에 관한 테스트 위주로 작성
    @sparcsJara
    sparcsJara committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7f598ab View commit details
    Browse the repository at this point in the history

  3. feat RacingHistories::recordRacingState :RacingState를 저장하는 메서드 구현 

    RacingFleet를 통해 RacingState를 저장하는 메서드 구현
    @sparcsJara
    sparcsJara committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    b738591 View commit details
    Browse the repository at this point in the history

  4. fix RacingWrapResultDTO: 안쓰는 import 제거 

    안쓰는 import 제거
    @sparcsJara
    sparcsJara committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    61e0dc8 View commit details
    Browse the repository at this point in the history

  5. refactor *.java: 린트 

    린트 적용
    @sparcsJara
    sparcsJara committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    0b77a40 View commit details
    Browse the repository at this point in the history

  6. refactor RandomMovableStrategy.java: RandomMovableStrategy 의존성 주입하는 부… 

    …분을 main으로 옮김

테스트하기 어려운 RandomMovableStrategy의 의존관계를 Object Graph의 상위인 main으로 옮김
    @sparcsJara
    sparcsJara committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    0186187 View commit details
    Browse the repository at this point in the history

  7. refactor CarRacingTest.java, RacingCarSimulatorTest.java: RandomMovab… 

    …leStrategy 대신에 ()->true를 주입함

테스트가 특정 movableStrategy에 의존하지 않도록함.
    @sparcsJara
    sparcsJara committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    531142a View commit details
    Browse the repository at this point in the history