Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding mysql-adapter #11856

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

adding mysql-adapter #11856

wants to merge 3 commits into from

Conversation

MAHB98
Copy link

@MAHB98 MAHB98 commented Sep 16, 2024

☕️ Reasoning

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

@MAHB98 MAHB98 requested review from 0ubbe and ndom91 as code owners September 16, 2024 23:43
@vercel Vercel
Copy link

vercel bot commented Sep 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ❌ Failed (Inspect) Jan 25, 2025 8:22am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jan 25, 2025 8:22am

@vercel Vercel
Copy link

vercel bot commented Sep 16, 2024

@MAHB98 is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the adapters Changes related to the core code concerning database adapters label Sep 16, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Sep 25, 2024 •
edited
Loading

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@auth/[email protected] environment Transitive: network +9 4.06 MB balazsorban
npm/@solidjs/[email protected] None 0 20.4 kB ryansolid
npm/@solidjs/[email protected] None 0 87.6 kB ryansolid
npm/[email protected] environment, filesystem +3 370 kB ai
npm/[email protected] None +3 3.26 MB ryansolid
npm/[email protected] environment, filesystem Transitive: eval, network, shell, unsafe +65 10.2 MB ryansolid
npm/[email protected] filesystem, shell Transitive: environment, eval, network, unsafe +118 10.9 MB ryansolid
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +335 45.8 MB ryansolid
npm/[email protected] environment, filesystem Transitive: network, shell, unsafe +101 14.9 MB adamwathan
npm/[email protected] None 0 40.6 MB typescript-bot
npm/[email protected] environment, eval, filesystem, network, shell, unsafe +8 10.3 MB vitebot
npm/[email protected] None 0 667 kB colinmcd94

🚮 Removed packages: npm/@actions/[email protected], npm/@ariakit/[email protected], npm/@aws-sdk/[email protected], npm/@aws-sdk/[email protected], npm/@azure/[email protected], npm/@balazsorban/[email protected], npm/@builder.io/[email protected], npm/@builder.io/[email protected], npm/@cloudflare/[email protected], npm/@eslint/[email protected], npm/@eslint/[email protected], npm/@graphql-codegen/[email protected], npm/@graphql-codegen/[email protected], npm/@graphql-typed-document-node/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

bherila
bherila suggested changes Dec 31, 2024
View reviewed changes
Copy link

@bherila bherila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits to suggest but I am planning on adopting this myself to avoid pulling a heavy-weight ORM into my own project.

packages/adapter-mysql/package.json
"url": "git+https://github.com/MAHB98/mysql-adapter.git"
},
"keywords": [

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove blank line

packages/adapter-mysql/package.json
"author": "MAHB98",
"license": "ISC",
"bugs": {
"url": "https://github.com/MAHB98/mysql-adapter/issues"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL doesn't exist- remove or replace with this repo's issues

packages/adapter-mysql/package.json
"tslib": "^2.6.3"
},
"devDependencies": {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra line

packages/adapter-mysql/package.json
"homepage": "https://github.com/MAHB98/mysql-adapter#readme",
"dependencies": {
"@auth/core": "^0.34.1",
"tsc": "^2.0.4",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsc is deprecated

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i remove tsc from dependencies and repositories is now in place

@bherila
Copy link

bherila commented Dec 31, 2024

Personally I would love to have this, although it'd also be nice if it were updated to support the new passkeys/webauthn functionality.

@MAHB98 MAHB98 requested a review from bherila January 25, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0ubbe 0ubbe Awaiting requested review from 0ubbe

@ndom91 ndom91 Awaiting requested review from ndom91 ndom91 is a code owner

@bherila bherila Awaiting requested review from bherila

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
adapters Changes related to the core code concerning database adapters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MAHB98 @bherila