fix(pages): recouple button theme to colorScheme and fix appearance for some logos in dark mode #12537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@EdmundDong is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
ThangHuuVu
approved these changes
Feb 2, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12537 +/- ##
==========================================
- Coverage 39.43% 39.42% -0.01%
==========================================
Files 198 198
Lines 31288 31285 -3
Branches 1370 1376 +6
==========================================
- Hits 12337 12334 -3
Misses 18951 18951 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
The theme of provider buttons do not comply with
AuthConfig.theme.colorSchemeand will instead comply with the system theme at all times. This PR recouples the button theme with theAuthConfig.theme.colorSchemeconfiguration option.This PR also inverts the colors of the following Provider logos in the dark theme to make them more visible (similar to #12379):
Before:
colorScheme: autocolorScheme: darkcolorScheme: lightsystem: darksystem: lightAfter:
colorScheme: autocolorScheme: darkcolorScheme: lightsystem: darksystem: light🧢 Checklist
🎫 Affected issues
📌 Resources