-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(provider): Microsoft Entra ID #12616
base: main
Are you sure you want to change the base?
Conversation
Clarified the usage of issuer parameter
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@benhovinga is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
7005e71
to
27486d5
Compare
27486d5
to
7005e71
Compare
Co-authored-by: Robin <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12616 +/- ##
==========================================
- Coverage 39.41% 39.04% -0.38%
==========================================
Files 198 198
Lines 31294 31644 +350
Branches 1376 1378 +2
==========================================
+ Hits 12334 12354 +20
- Misses 18960 19290 +330 ☔ View full report in Codecov by Sentry. |
☕️ Reasoning
This PR resolves several issues with the Microsoft Entra ID provider.
Fix Documentation
Inconsistencies between the use of
issuer
andtenantId
. This implementation of the provider doesn't directly usetenantId
however it is used within part of theissuer
URI string. This PR clarifies how to use theissuer
parameter in both the Provider Docs and API Reference.Also fixed some inconsistencies between frameworks
Fix
MicrosoftEntraIDProfile
interfaceThe
MicrosoftEntraIDProfile
interface was missing a lot of the claims returned from the provider server. This PR adds allid_token
claims.Fix default issuer
If the environment variable
AUTH_MICROSOFT_ENTRA_ID_ISSUER
is configured but theissuer
parameter is not set, the default issuer overwrites the environment variable. This PR checks if the environment variable is configured first before falling back to the default issuer.Now the provider "can" be used without any configuration, like this.
Finish Provider Implementation
Add the provider to the OAuth providers search and the Issues Template providers dropdown.
🧢 Checklist
🎫 Affected issues
Fixes: #12314, #12193, #12195
Corrects: #12612
📌 Resources