fix: check if emails exist in userInfo callback of GitHub provider #12667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@nikita-lepikhin is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
nikita-lepikhin
force-pushed
the
fix/github-userinfo-emails
branch
from
2eb32d8 to
4b8605a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a JS check for whether the request to GitHub's
/public_emailsactually returns any public emails. Before the change, the code would fail if GitHub API did not return any public emails. Any error thrown in the userInfo callback would abort the OAuth login flow.The user does not have to have a public email set. All registered emails could be hidden in
Settings->Emails->Keep my email addresses private.