Reapply "docs: exclude inherits, update deps (#12628)" (#12645) #12690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ThangHuuVu
commented
Feb 22, 2025
•
ThangHuuVu
commented
- Upgrade typedoc & plugins
- Added jonchardy/typedoc-plugin-no-inherit
- remove warnings.mdx, instead put it in the source code. Updated the reference in the logs to point to the new destination
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
github-actions
bot
added
providers
adapters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12690 +/- ##
==========================================
+ Coverage 39.46% 39.63% +0.17%
==========================================
Files 198 198
Lines 31306 31397 +91
Branches 1372 1372
==========================================
+ Hits 12354 12445 +91
Misses 18952 18952 ☔ View full report in Codecov by Sentry. |
ndom91
approved these changes
Feb 23, 2025
ThangHuuVu
commented
Feb 23, 2025
| @@ -32,6 +32,7 @@ packages/next-auth/providers | |||
| # copied from @auth/core | |||
| packages/frameworks-*/**/providers | |||
| packages/*/*.js | |||
| !packages/*/typedoc.config.js | |||
There was a problem hiding this comment.
have to convert some files to .js so this will prevent the file from being deleted by clean scripts
ThangHuuVu
commented
Feb 23, 2025
| @@ -72,7 +72,7 @@ export default withNextra({ | |||
| { | |||
| source: "/:path(.*)", | |||
| has: [{ type: "host", value: "warnings.authjs.dev" }], | |||
| destination: "https://authjs.dev/reference/warnings/:path*", | |||
| destination: "https://authjs.dev/reference/core/errors#warningcode", | |||
There was a problem hiding this comment.
TBD: should we put warning code under /errors or we make a new file for it in the source code.
ThangHuuVu
commented
Feb 23, 2025
There was a problem hiding this comment.
had to convert this file to ESM because of [email protected]
ThangHuuVu
commented
Feb 23, 2025
| ], | ||
| disableSources: true, | ||
| excludeNotDocumented: true, | ||
| excludeExternals: true, | ||
| excludeInternal: true, | ||
| excludePrivate: true, |
ThangHuuVu
commented
Feb 23, 2025
| @@ -75,8 +76,5 @@ module.exports = { | |||
| expandObjects: true, | |||
| parametersFormat: "table", | |||
| indexFormat: "table", | |||
| textContentMappings: { | |||
There was a problem hiding this comment.
not sure about this - I feel like it's unnecessary. This option is also deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.