AIO: add Unhealthy container state #5307
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
docjyJ
commented
Sep 21, 2024
docjyJ
commented
- Add Unhealty state
- Replace class by backed enum
szaimen
added
3. to review
21 tasks
st3iny
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Hey Jean-Yves, Simon asked me to have a look at your changes. I left some feedback regarding the code itself.
I really like you refactoring the container state logic from an interface to an enum. However, I think that both concerns could have been split into separate PRs. One PR to refactor the interface and another one to implement the new healthy states. But the code is already there so why not.
Looks good otherwise but did not test.
|
Hi, Thanks for the answer, as soon as I have time I'll look into it. I will try to separate and make several PR. Take care, |
7 tasks
docjyJ
added
2. developing
|
I keep this PR open for the unhealthy state. |
Signed-off-by: Jean-Yves <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
docjyJ
force-pushed
the
ench/noid/heathcheck
branch
from
1f3f231
to
b9ca83a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.