Add Sync Worker #14166
Open
Add Sync Worker #14166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alperozturk96
force-pushed
the
feature/sync-worker
branch
from
8da1e10 to
d017482
Compare
alperozturk96
force-pushed
the
feature/sync-worker
branch
3 times, most recently
from
57990c8 to
0c5db2c
Compare
alperozturk96
commented
Dec 19, 2024
|
|
||
| private fun getFiles(folder: OCFile, storageManager: FileDataStorageManager): List<OCFile> = | ||
| storageManager.getAllFilesRecursivelyInsideFolder(folder) | ||
| .filter { !it.isFolder && !it.isDown } |
There was a problem hiding this comment.
Same logic we have in the SynchronizeFolderOperation.prepareOpsFromLocalKnowledge()
alperozturk96
commented
Dec 19, 2024
| @@ -500,7 +499,7 @@ private void startDirectDownloads() { | |||
| Log_OC.d(TAG, "Exception caught at startDirectDownloads" + e); | |||
| } | |||
| } else { | |||
| mFilesForDirectDownload.forEach(file -> fileDownloadHelper.downloadFile(user, file)); | |||
| fileDownloadHelper.syncFolder(mLocalFolder); | |||
There was a problem hiding this comment.
Since SyncWorker is responsible for preparing the files, there is no need to pass an array of files to the worker. Additionally, in scenarios where a user attempts to sync a large number of files (e.g., 1,000 files), the app could freeze or crash due to limitations associated with passing a large amount of data between classes via inputData.
4 tasks
1 task
alperozturk96
force-pushed
the
feature/sync-worker
branch
from
4da8950 to
41d9f2e
Compare
alperozturk96
force-pushed
the
feature/sync-worker
branch
from
41d9f2e to
5f8baf6
Compare
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
alperozturk96
force-pushed
the
feature/sync-worker
branch
from
5f8baf6 to
5422ca6
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14166.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
• Fixed the issue of scheduling too many FileDownloadWorker instances for folder sync.
• Resolved the issue of retrieving sub-folder items for the selected folder.
• Improved file download status observation, including states like syncing, downloading, and downloaded.
• Better constraints for worker
• Enhanced folder sync progress observation in notifications.
• Optimized performance using CoroutineWorker.
Demo
swd.mp4
big_file_test.mp4
Known Issues
• The current codebase does not efficiently handle the observation of the download states such as downloading, downloaded, cancelled. The swapDirectory() method must be called to display the green tick icon after each download, which is not an ideal approach. Additionally, invoking notifyItemChanged() does not impact the return value of the isDown() function, resulting in the downloaded file not being recognized as such. Thus, green tick cannot be set after file download completion.
A more robust solution could be considered; please feel free to suggest any viable alternatives.