Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not continue when server fails #14453

Merged
merged 2 commits into from
Jan 23, 2025
Merged

do not continue when server fails #14453

merged 2 commits into from
Jan 23, 2025

Conversation

tobiasKaminsky
Copy link
Member

  • Tests written, or not not needed

@tobiasKaminsky
do not continue when server fails
6034539 
Signed-off-by: tobiasKaminsky <[email protected]>
@tobiasKaminsky
1
56f3b2d 
Signed-off-by: tobiasKaminsky <[email protected]>
@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14453.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5555
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5758
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total503504

SpotBugs increased!

@tobiasKaminsky tobiasKaminsky merged commit 890464a into master Jan 23, 2025
17 of 22 checks passed
@tobiasKaminsky tobiasKaminsky deleted the failOnServerFail branch January 23, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2. developing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tobiasKaminsky