PropagateDownloadFile: Allow symlink to be larger than 8kB

Signed-off-by: Tamino Bauknecht <[email protected]>
nextcloud · Dec 8, 2023 · 1c9112a · 1c9112a
1 parent 9a445e0
commit 1c9112a
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 5 deletions.
diff --git a/src/libsync/propagatedownload.cpp b/src/libsync/propagatedownload.cpp
@@ -33,6 +33,7 @@
 #include <QFileInfo>
 #include <QDir>
 #include <cmath>
+#include <optional>
 
 #ifdef Q_OS_UNIX
 #include <unistd.h>
@@ -290,12 +291,29 @@ qint64 GETFileJob::writeToDevice(const QByteArray &data)
     return _device->write(data);
 }
 
+bool GETFileJob::writeSymlink(const QString &symlinkTarget)
+{
+    auto file_device = qobject_cast<QFile*>(_device);
+    if (!file_device) {
+        qCWarning(lcGetJob) << "Unable to create symlink on given device!";
+        return false;
+    }
+    file_device->close();
+    FileSystem::remove(file_device->fileName());
+    if (!QFile::link(symlinkTarget, file_device->fileName())) {
+        qCWarning(lcGetJob) << "Error creating symlink '" << file_device->fileName() << '\'';
+        return false;
+    }
+    return true;
+}
+
 void GETFileJob::slotReadyRead()
 {
     if (!reply())
         return;
     int bufferSize = qMin(1024 * 8ll, reply()->bytesAvailable());
     QByteArray buffer(bufferSize, Qt::Uninitialized);
+    std::optional<QString> symlinkTarget;
 
     while (reply()->bytesAvailable() > 0 && _saveBodyToFile) {
         if (_bandwidthChoked) {
@@ -323,11 +341,11 @@ void GETFileJob::slotReadyRead()
 
         if (reply()->hasRawHeader("OC-File-Type") &&
             reply()->rawHeader("OC-File-Type").toInt() == ItemTypeSoftLink) {
-            // TODO: handle non-Unix OS
-            auto file_device = static_cast<QFile*>(_device);
-            file_device->close();
-            FileSystem::remove(file_device->fileName());
-            QFile::link(QString(buffer), file_device->fileName());
+            if (symlinkTarget) {
+                *symlinkTarget += buffer;
+            } else {
+                symlinkTarget = buffer;
+            }
         } else {
             const qint64 writtenBytes = writeToDevice(QByteArray::fromRawData(buffer.constData(), readBytes));
             if (writtenBytes != readBytes) {
@@ -340,6 +358,11 @@ void GETFileJob::slotReadyRead()
         }
     }
 
+    if (symlinkTarget && !writeSymlink(*symlinkTarget)) {
+        reply()->abort();
+        return;
+    }
+
     if (reply()->isFinished() && (reply()->bytesAvailable() == 0 || !_saveBodyToFile)) {
         qCDebug(lcGetJob) << "Actually finished!";
         if (_bandwidthManager) {

diff --git a/src/libsync/propagatedownload.h b/src/libsync/propagatedownload.h
@@ -115,6 +115,7 @@ class OWNCLOUDSYNC_EXPORT GETFileJob : public AbstractNetworkJob
 
 protected:
     virtual qint64 writeToDevice(const QByteArray &data);
+    virtual bool writeSymlink(const QString &symlinkTarget);
 
 signals:
     void finishedSignal();