Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to redirect instead of IFrame for some setups #43

Merged
merged 1 commit into from
Jun 21, 2017

Conversation

nickvergessen
Copy link
Member

Fix #27

@MorrisJobke in case you want to review this

@nickvergessen nickvergessen merged commit d513c1d into master Jun 21, 2017
@nickvergessen nickvergessen deleted the redirect-option branch June 21, 2017 11:50
@radiantwave
Copy link

Also please add an option to open in new tab!

@nickvergessen
Copy link
Member Author

Sorry that is not possible, because of how the menu navigation is generated by the server.

@pirate
Copy link

pirate commented Sep 10, 2017

It is possible if it shares code with ownCloud @nickvergessen, I finished this recently for ownCloud and will be submitting a PR to nextcloud soon: owncloud-archive/apps#2221

It's a PR that adds a user configurable option for the link taget: '_blank', '_top', '_self' (new window/tab, replace current tab, open in iframe).

@nickvergessen
Copy link
Member Author

Yeah well, our menu navigation is different from the owncloud one ;)

@pirate
Copy link

pirate commented Sep 13, 2017

Cool, didn't realize the code diverged that much from OC.

  • opening link in iframe (default)
  • redirecting current window to link (finished in this PR)
  • opening link in new window

To get the final new window functionality, could we do something like:

  1. user clicks external site link, goes to /external/1/
  2. on /external/1/ the following JS executes:
window.open(external_url);
window.history.back();
  1. they are sent back to their previous page, and the link is opened in a new tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants