feat: Provide limit via dav property #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Pytal
commented
Mar 15, 2024
Pytal
commented
- Resolve limit info in webdav request #239
Pytal
force-pushed
the
feat/dav
branch
3 times, most recently
from
9ccb708
to
6a2bb12
Compare
artonge
reviewed
Mar 18, 2024
| return new LimitList([]); | ||
| } | ||
|
|
||
| $externalShares = $this->getSharesForTypes( |
There was a problem hiding this comment.
Aren't we in the context of a specific share here? So the limit should be relative to the share and not every share.
Or maybe I missed something.
There was a problem hiding this comment.
The context is a single file node which can have multiple external shares
There was a problem hiding this comment.
So the answer is for the share owner when he edits the share?
There was a problem hiding this comment.
This would be for clients I guess as requested in this issue #239, no plan to use this for the web UI
There was a problem hiding this comment.
Ok, not sure what is the purpose then 🤔
There was a problem hiding this comment.
Any more details on clients-side @tobiasKaminsky?
skjnldsv
reviewed
Mar 19, 2024
artonge
approved these changes
Mar 19, 2024
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.