Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] Fix npm audit #763

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Conversation

nextcloud-command
Copy link
Contributor

Auto-generated fix of npm audit

@nextcloud-command nextcloud-command added 3. to review dependencies Pull requests that update a dependency file labels Jun 25, 2023
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable24-fix-npm-audit branch from f9afd52 to 9e5fa6f Compare July 2, 2023 03:28
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable24-fix-npm-audit branch from 9e5fa6f to fca7ccf Compare July 9, 2023 03:54
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable24-fix-npm-audit branch from fca7ccf to d71707e Compare July 10, 2023 14:19
@szaimen szaimen requested a review from danxuliu July 10, 2023 14:20
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Since PDF.js was bumped to 2.5.207 in 4705de4 the event listened to
is "DOMContentLoaded" rather than "webviewerloaded".

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
@danxuliu
Copy link
Member

/compile /

Signed-off-by: nextcloud-command <[email protected]>
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Smoke) Tested and works 👍

PHPUnit summary workers did not run, but that is unrelated and it can be fixed in another pull request.

@danxuliu danxuliu merged commit dcd9ed7 into stable24 Jul 12, 2023
12 checks passed
@delete-merged-branch delete-merged-branch bot deleted the automated/noid/stable24-fix-npm-audit branch July 12, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants