Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] Fix extraction of PDF.js package #808

Merged

Conversation

danxuliu
Copy link
Member

Backport of #806

This also adds back the files deleted after rebuilding when unzipper version was bumped

It seems that in some cases "unzipper" may not extract all the files
and, with some node versions, it may corrupt some of the extracted
files. As there is no fix for all that yet (downgrading "unzipper" to
0.10.11 might solve the missing extracted files, but it would still be
affected by the corrupted files and thus prevent upgrading to a newer
node version) "unzipper" was replaced by "adm-zip".

"adm-zip" does not have dependencies and has a large user base.
Unfortunately it does not support streams and requires loading the whole
file in memory to be able to extract it, but the package is not very
large (around 5,5 MiB), so this should not be a problem.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
@danxuliu danxuliu added bug 3. to review dependencies Pull requests that update a dependency file labels Aug 21, 2023
@danxuliu danxuliu added this to the Nextcloud 26.0.6 milestone Aug 21, 2023
@danxuliu danxuliu requested a review from szaimen August 21, 2023 16:50
@danxuliu danxuliu merged commit 58a8b1d into stable26 Aug 21, 2023
17 checks passed
@delete-merged-branch delete-merged-branch bot deleted the backport/806/stable26-fix-extraction-of-pdf.js-package branch August 21, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants