Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix focus lost to body when closing firstrunwizard #1073

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Feb 1, 2024

@Pytal
Copy link
Member Author

Pytal commented Feb 1, 2024

/backport 99d0777 to stable28

@szaimen
Copy link
Collaborator

szaimen commented Feb 2, 2024

I tested this and it doesnt seem to work since the menu seems to close when you open the firstrunwizard:

recordedVideo2024-02-02-124820.mp4

Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my eyes it works well, thank you!

But actually this app is disabled and it was decided to leave firstrunwizard disabled

@Pytal Pytal merged commit ba1023c into master Feb 2, 2024
36 checks passed
@Pytal Pytal deleted the fix/a11y/wizard-modal-return-focus branch February 2, 2024 13:31
@Pytal
Copy link
Member Author

Pytal commented Feb 2, 2024

I tested this and it doesnt seem to work since the menu seems to close when you open the firstrunwizard:

Maybe not intuitive but the menu is supposed to close and the focus returns to the avatar button

But actually this app is disabled and it was decided to leave firstrunwizard disabled

Right!

@szaimen
Copy link
Collaborator

szaimen commented Feb 2, 2024

Maybe not intuitive but the menu is supposed to close and the focus returns to the avatar button

Yes, definitely not intuitive. Shouldnt the menu stay open?

@Pytal
Copy link
Member Author

Pytal commented Feb 2, 2024

Yes, definitely not intuitive. Shouldnt the menu stay open?

Nope, was discussed already that only when the menu is open it retains focus and is otherwise closed for a11y

@szaimen
Copy link
Collaborator

szaimen commented Feb 2, 2024

Yes, definitely not intuitive. Shouldnt the menu stay open?

Nope, was discussed already that only when the menu is open it retains focus and is otherwise closed for a11y

All right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV] Focus is lost to body when closing firstrunwizard
3 participants