Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check to prevent users from revoking their own access #2960

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented May 14, 2024

When changing ACL rules, check if the new rule set would lead the current user without read permissions

  • make the UI properly handle the error
  • (maybe) add an option to force revoking the access anyway

@icewind1991 icewind1991 added the 2. developing Items that are currently under development label May 14, 2024
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@icewind1991 since you said

Would it maybe make more sense to just fully prevent users from revoking their own access?

I would say the modal is better, because maybe you do want to get out of the group folder?

Access removal
Proceeding will remove your own access to this group folder.
[ Cancel ] [ Remove own access ]

@provokateurin
Copy link
Member

Fixes #2822

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Items that are currently under development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants