Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add tests for Events #3261

Merged
merged 1 commit into from
Sep 20, 2024
Merged

test: Add tests for Events #3261

merged 1 commit into from
Sep 20, 2024

Conversation

provokateurin
Copy link
Member

No description provided.

@provokateurin provokateurin added the 3. to review Items that need to be reviewed label Sep 20, 2024
Signed-off-by: provokateurin <[email protected]>
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those kind of tests usefull? They really feel like tautologies.

@provokateurin
Copy link
Member Author

I think it's good to have them so that we can easily adapt the tests if the events ever get some more logic that would need tests.

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@come-nc come-nc merged commit b31c379 into master Sep 20, 2024
41 checks passed
@come-nc come-nc deleted the test/events branch September 20, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants