Skip to content

Commit

Permalink
fix(EnvelopeSkeleton): add filler on hover to prevent text shifting
Browse files Browse the repository at this point in the history
Signed-off-by: Grigory Vodyanov <[email protected]>
  • Loading branch information
GVodyanov committed Jan 19, 2025
1 parent 07f71c2 commit c247975
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions src/components/EnvelopeSkeleton.vue
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@
<div v-show="forceDisplayActions || displayActionsOnHoverFocus"
class="list-item__actions"
@focusout="handleBlur">
<!-- These details aren't actually displayed, they are just there to prevent text jittering on hover -->
<div class="list-item__actions__filler">
<slot name="list-item__actions__filler">{{ details }}</slot>

Check warning on line 88 in src/components/EnvelopeSkeleton.vue

View workflow job for this annotation

GitHub Actions / NPM lint

Expected 1 line break after opening tag (`<slot>`), but no line breaks found

Check warning on line 88 in src/components/EnvelopeSkeleton.vue

View workflow job for this annotation

GitHub Actions / NPM lint

Expected 1 line break before closing tag (`</slot>`), but no line breaks found
</div>
<NcActions ref="actions"
:primary="isActive || active"
:aria-label="computedActionsAriaLabel"
Expand Down Expand Up @@ -633,6 +637,15 @@ export default {
justify-content: center;
align-self: start;
margin-top: 0;
display: flex;
flex-direction: column-reverse;
align-items: flex-end;

&__filler {
padding-right: calc(var(--default-grid-baseline) * 2);
visibility: hidden;
margin-left: calc(var(--default-grid-baseline) * 2 + 1px);
}
}

}
Expand Down

0 comments on commit c247975

Please sign in to comment.