Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decoding preview texts #10647

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix: decoding preview texts #10647

merged 1 commit into from
Feb 4, 2025

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Feb 3, 2025

Resolves #8776

Problem: A MIME part's encoding was not respected when generating preview texts. Only the transfer encoding header was used but not the content type (charset parameter).

Respect the content type charset when decoding bodies to use when generating preview texts.

Screenshots

Before After
spectacle_20250203_165247 spectacle_20250203_164844

@st3iny
Copy link
Member Author

st3iny commented Feb 3, 2025

/backport to stable4.1

@st3iny
Copy link
Member Author

st3iny commented Feb 3, 2025

/backport to stable3.7

@st3iny st3iny added this to the v4.2.0 milestone Feb 3, 2025
Respect the content type charset when decoding bodies to use when
generating preview texts.

Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny st3iny force-pushed the fix/preview-text-encoding branch from d5a458c to 945b4a2 Compare February 4, 2025 14:56
@st3iny st3iny enabled auto-merge February 4, 2025 14:56
@st3iny st3iny disabled auto-merge February 4, 2025 16:11
@st3iny st3iny merged commit 584ef81 into main Feb 4, 2025
33 of 35 checks passed
@st3iny st3iny deleted the fix/preview-text-encoding branch February 4, 2025 16:11
@st3iny st3iny modified the milestones: v4.2.0, v4.3.0 Feb 24, 2025
@st3iny
Copy link
Member Author

st3iny commented Feb 24, 2025

/backport to stable4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

Encoding issues with the preview of a message
2 participants