-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: detect imip messages from outlook.com #10661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming writing a unit test for this is not trivial, is it?
We should have tests for it 🙏 Richard did some tests for smime, I will have a look if we can start from there. |
Adjust the parsing logic in MessageMapper to correctly detect iMIP messages in flat email structures where the text/calendar part is not wrapped in multipart/alternative. Signed-off-by: Daniel Kesselberg <[email protected]>
43f49e0
to
b965355
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😻
/backport to stable4.2 |
/backport to stable3.7 |
The backport to # Switch to the target branch and update it
git checkout stable3.7
git pull origin stable3.7
# Create the new backport branch
git checkout -b backport/10661/stable3.7
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b9653556
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/10661/stable3.7 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
/backport to stable4.1 |
RFC examples of possible iMip Messages |
Fix #10660
Adjust the parsing logic in MessageMapper to correctly detect iMIP messages in flat email structures where the text/calendar part is not wrapped in multipart/alternative.
The implementation loops over the message parts and then tries to fetch another part. This works for Gmail because the iMIP message is wrapped in multipart/alternative, but fails for Outlook.com, where the text/calendar part is not nested.
partIterator returns all parts, including nested ones.
Gmail:
Outlook.com: