fix: always show email address for suggestions from address collector

[kesselb]

Have oc_mail_coll_addresses with:

user_id	email	display_name
admin	[email protected]	Bob
admin	[email protected]	Bob

B

A

[kesselb]

/backport to stable4.2

[kesselb]

/backport to stable4.1

[kesselb]

/backport to stable3.7

[ChristophWurst]

would it make sense to explicitly check for null or an empty string? what makes a truthy displayname?

[kesselb]

Sure, now it's really matching the implemention in contacts integration ;)

[ChristophWurst]

Doesn't that mean we'll also send the email to a recipient Jane Doe ([email protected]) <[email protected]> instead of just Jane Doe <[email protected]>?

[kesselb]

Doesn't that mean we'll also send the email to a recipient Jane Doe ([email protected]) [email protected] instead of just Jane Doe [email protected]?

Indeed, that's not ideal.

I initially did it in the frontend until I learned that we are using this format for the contacts' integration already. Let me move it back to the frontend and overload the options template for nc/vue select.

[kesselb]

Good that we took a second look. It's already there, just using the wrong prop, apparently.

mail/src/components/Composer.vue

Lines 85 to 90 in 4b1b6ca

	<ListItemIcon :no-margin="true"
	:name="option.label"
	:subtitle="option.email"
	:icon-class="!option.id ? 'icon-user' : null"
	:url="option.photo"
	:avatar-size="24" />

subtitle => subname

[kesselb]

I've updated the patch to show the email address as subname again if label != email.

1. It was not enough to just rename subtitle to subname because the subname is only shown when the avatar size is larger than 24. It's using the default of 32 now. I don't know if that plays well with the new smaller design. @nimishavijay @GretaD could you please check the screenshot's in the first post?

2. @ChristophWurst the issue, that the sender name is weird, is still there for recipients from the contacts integration service. Please let me know if you want to address this in this pr or do a follow-up. The purpose for this change was to improve the usability for the recipients from the address collector.

[ChristophWurst]

Very nice! I like the sublinename approach

It's fine to do the follow up. This can be put into a ticket.