fix(deps): Do not ship psr/log #10706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
commented
Feb 17, 2025
ChristophWurst
commented
Feb 17, 2025
| @@ -63,16 +63,16 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| php-versions: ['8.3'] | |||
| nextcloud-versions: ['master'] | |||
| nextcloud-versions: ['chore/mail-bisect-6e1d9a26209ec5524fbc2fb9c7cbb53315e64d72'] | |||
There was a problem hiding this comment.
This is because of #10688 (comment). I need a slightly outdated server checkout for CI. Right now that means we don't get the latest server master results, but I'm mostly interested in getting this to stable4.2
It is provided by server's 3rdparty. Shipping another copy can lead to a dependency hell. Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/deps/no-psr-log-shipping
branch
from
8af2238 to
2f8f9bd
Compare
|
/backport to stable4.2 |
This was referenced Feb 17, 2025
devnoname120
added a commit
to devnoname120/epubviewer
that referenced
this pull request
Feb 27, 2025
Nextcloud broke things again in an update without mentioning it in the changelog. A ton of apps are impacted (not just epubviewer). This commit uses a trick to prevent epubviewer's dependencies from installing `Psr\Log` and instead use the one diretly shipped in the dependencies of Nextcloud 31. Fix #29 (comment) Related: - nextcloud/mail#10644 - ChristophWurst/nextcloud_sentry#701 - nextcloud/mail#10706 - nextcloud/mail#10658 - ihttps://github.com/nextcloud/mail/pull/10708 - And many more…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is provided by server's 3rdparty. Shipping another copy can lead to a dependency hell.
psr/log is now installed only for Psalm to have stubs. This avoids vendoring stubs in our repo, which would get outdated one day. Renovate will help us keep the stub package updated.
Fixes #10658
How to test
composer ito wipe the old psr/logThe app should work the same as on
main.