-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter messages sent in the last 7 days and from me #9509
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
I think the filter shortcuts should be regular buttons, not radio buttons |
2b35c37
to
4fae23a
Compare
@st3iny had a comment that he would prefer that the "has attachment" to be a checkbox instead of a button. I left it as a button, as it was requested that the shortcuts to be buttons. But i can change it again, if more agree with Richard. |
85add33
to
ea7103b
Compare
Please disregard my comment regarding the checkbox. I was under the impression that the buttons are shown in the search popover instead of below it. It makes sense for them to be buttons when they are shown directly below the search field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The search is not reset after disabling a button again. I guess that should work?
E.g. I click Last 7 days
and then click it again and expect that all mails are now shown again as the filter is toggled. However, the filter stays on last 7 days even if the button is not primary any longer.
2024-04-22.09-53-32.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works.
Please rebase to solve conflicts and squash all commits. |
2b75011
to
626140c
Compare
Signed-off-by: greta <[email protected]>
626140c
to
16edc13
Compare
fixes #9182
with pressed state