Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter messages sent in the last 7 days and from me #9509

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Apr 2, 2024

fixes #9182

with pressed state

Screenshot from 2024-04-18 13-23-12
Screenshot from 2024-04-18 13-22-38

@GretaD GretaD self-assigned this Apr 2, 2024
@GretaD GretaD changed the title Filter messages last 7 days Filter messages sent the last 7 days Apr 2, 2024
@GretaD GretaD changed the title Filter messages sent the last 7 days Filter messages sent in the last 7 days Apr 2, 2024
@GretaD GretaD changed the title Filter messages sent in the last 7 days Filter messages sent in the last 7 days and from me Apr 3, 2024
@GretaD GretaD marked this pull request as ready for review April 4, 2024 15:34
@GretaD GretaD requested a review from ChristophWurst as a code owner April 4, 2024 15:34
@GretaD GretaD marked this pull request as draft April 4, 2024 15:37
@GretaD

This comment was marked as outdated.

@ChristophWurst
Copy link
Member

I think the filter shortcuts should be regular buttons, not radio buttons

@GretaD GretaD force-pushed the feat/filtering-messages branch from 2b35c37 to 4fae23a Compare April 16, 2024 11:12
@GretaD GretaD requested review from hamza221 and st3iny April 16, 2024 15:10
@GretaD GretaD marked this pull request as ready for review April 16, 2024 15:10
@GretaD
Copy link
Contributor Author

GretaD commented Apr 16, 2024

@st3iny had a comment that he would prefer that the "has attachment" to be a checkbox instead of a button. I left it as a button, as it was requested that the shortcuts to be buttons. But i can change it again, if more agree with Richard.

@GretaD GretaD force-pushed the feat/filtering-messages branch from 85add33 to ea7103b Compare April 18, 2024 11:29
@st3iny
Copy link
Member

st3iny commented Apr 22, 2024

Please disregard my comment regarding the checkbox. I was under the impression that the buttons are shown in the search popover instead of below it. It makes sense for them to be buttons when they are shown directly below the search field.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search is not reset after disabling a button again. I guess that should work?

E.g. I click Last 7 days and then click it again and expect that all mails are now shown again as the filter is toggled. However, the filter stays on last 7 days even if the button is not primary any longer.

2024-04-22.09-53-32.mp4

@GretaD GretaD requested a review from st3iny April 23, 2024 07:30
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@st3iny
Copy link
Member

st3iny commented Apr 23, 2024

Please rebase to solve conflicts and squash all commits.

@GretaD GretaD force-pushed the feat/filtering-messages branch from 2b75011 to 626140c Compare April 23, 2024 11:09
@GretaD GretaD force-pushed the feat/filtering-messages branch from 626140c to 16edc13 Compare April 23, 2024 11:10
@GretaD GretaD enabled auto-merge April 23, 2024 11:10
@GretaD GretaD merged commit ee63a7f into main Apr 24, 2024
33 of 34 checks passed
@GretaD GretaD deleted the feat/filtering-messages branch April 24, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add filter shortcuts (like Has attachment, Last 7 days and From me)
3 participants