Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scopes): Limit tag names #101

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

provokateurin
Copy link
Member

Closes #99

Tags should be limited to certain characters to avoid developers using strange things that could break generators.

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine in general, I'd like to see numbers as well, for some buzzwords flying around like 2FA, id4me, etc if you don't have a technical reason to block them

@provokateurin
Copy link
Member Author

Yeah I guess numbers would be fine as well.

Signed-off-by: provokateurin <[email protected]>
@nickvergessen nickvergessen merged commit 09030f8 into main Mar 14, 2024
10 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/scopes/limit-tag-names branch March 14, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit tags in OpenAPI annotation to [a-zA-Z-_]
2 participants