fix: Ensure operationIds are unique #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
nickvergessen
approved these changes
Apr 9, 2024
|
Still kind of meh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98
Tags are not longer used for the operationId because it is possible to tag two controller methods with the same names in two different controllers with the same tag and the output would be the same operationId. Talk is currently affected by this problem.
The failure results in a panic and can not be skipped because the result would be an invalid spec.
The CI for Talk will fail because it currently has a controller method with two routes that are not unique.