Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump NcVue to v8.4.0 #529

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Bump NcVue to v8.4.0 #529

merged 1 commit into from
Jan 3, 2024

Conversation

JuliaKirschenheuter
Copy link
Contributor

Resolves nextcloud/server#42264

Before After
image Screenshot from 2024-01-03 10-29-37

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jan 3, 2024
@JuliaKirschenheuter
Copy link
Contributor Author

/compile fixup /

@ShGKme
Copy link
Contributor

ShGKme commented Jan 3, 2024

It seems that title also should be replaced with name if I remember breaking changes correctly.

password_policy/src/AdminSettings.vue

Line 25 in efc7690

<NcSettingsSection :title="t('password_policy', 'Password policy')">

@ShGKme ShGKme force-pushed the bump/nc-vue-v8.4.0 branch from 443b336 to 995bd97 Compare January 3, 2024 13:39
@ShGKme ShGKme enabled auto-merge January 3, 2024 13:40
@JuliaKirschenheuter
Copy link
Contributor Author

/compile amend /

@JuliaKirschenheuter @nextcloud-command
Bump NcVue to v8.4.0
545d94b 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: julia.kirschenheuter <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@ShGKme ShGKme merged commit 89cb7b6 into master Jan 3, 2024
18 checks passed
@ShGKme ShGKme deleted the bump/nc-vue-v8.4.0 branch January 3, 2024 14:55
@github-actions GitHub Actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@emoral435 emoral435 Awaiting requested review from emoral435

@Pytal Pytal Awaiting requested review from Pytal

@susnux susnux Awaiting requested review from susnux

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review feedback-requested
Projects
None yet
Milestone
No milestone
2 participants
@JuliaKirschenheuter @ShGKme