Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(passwords): Fix password file generation #681

Merged
merged 2 commits into from
Oct 25, 2024
Merged

fix(passwords): Fix password file generation #681

merged 2 commits into from
Oct 25, 2024

Conversation

nickvergessen
Copy link
Member

  • SPDX headers were missing
  • Some files compiled "integer keys" as numbers, even when those were not numbers in the used PHP (32bit and more)
    grafik

grafik

So I replaced it with a manual array building ensuring that the keys of the array are strings.

@nickvergessen nickvergessen self-assigned this Oct 22, 2024
@nickvergessen
Copy link
Member Author

ah and due to missing source, I downloaded a new copy from the source listed in lists/README.md

@juliusknorr juliusknorr merged commit 51c5077 into master Oct 25, 2024
40 checks passed
@juliusknorr juliusknorr deleted the bugfix/noid/regenerate-password-lists branch October 25, 2024 10:24
@nickvergessen
Copy link
Member Author

Should we backport this?
the "numeric" ids in list-19.txt e.g. would still log on stable branches

@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @juliusknorr