Switch to @vladmandic/human #1237
Open
+2,584
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ghisch <[email protected]> Signed-off-by: QuentinLemCode <[email protected]>
Adapt dimensions to 1024 as outputed by @vladmandic/human Signed-off-by: ghisch <[email protected]> Signed-off-by: QuentinLemCode <[email protected]>
Signed-off-by: ghisch <[email protected]> Signed-off-by: QuentinLemCode <[email protected]>
Signed-off-by: ghisch <[email protected]> Signed-off-by: QuentinLemCode <[email protected]>
Signed-off-by: QuentinLemCode <[email protected]>
QuentinLemCode
force-pushed
the
switch-human
branch
from
4902d99 to
8c07aa7
Compare
QuentinLemCode
force-pushed
the
switch-human
branch
from
2912d52 to
e125841
Compare
|
Nothing productive to add, just a thank you that this is finallly being worked on <3 |
|
Mmh, not sure why we don't have CI here |
|
I'm really not sure why, but I had the option to click on "Approve and run" [the CI] so I just did and it worked 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR take the work from @ghisch and try to make it production ready
#1218