Skip to content

Commit

Permalink
Make ICommentsManager::load() function no-op and deprecate it
Browse files Browse the repository at this point in the history
  • Loading branch information
sorbaugh authored and nickvergessen committed Nov 2, 2023
1 parent 9b64532 commit 224e8eb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/private/Comments/Manager.php
Original file line number Diff line number Diff line change
Expand Up @@ -1616,10 +1616,10 @@ private function sendEvent($eventType, IComment $comment) {
* Load the Comments app into the page
*
* @since 21.0.0
* @deprecated 28.0.0 - Method is no-op because comments feature was moved to the activity app
*/
public function load(): void {
$this->initialStateService->provideInitialState('comments', 'max-message-length', IComment::MAX_MESSAGE_LENGTH);
Util::addScript('comments', 'comments-app');
$this->logger->critical('Method ' . __METHOD__ . ' is no-op because comments feature was moved');
}

/**
Expand Down
1 change: 1 addition & 0 deletions lib/public/Comments/ICommentsManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,7 @@ public function resolveDisplayName($type, $id);
* Load the Comments app into the page
*
* @since 21.0.0
* @deprecated 28.0.0 - Method is no-op because comments feature was moved to the activity app
*/
public function load(): void;

Expand Down

0 comments on commit 224e8eb

Please sign in to comment.