Merge pull request #40752 from nextcloud/enh/40654/share-creation-loa…

…ding-feedback Show loading icon in 'save share' button when creating a share
nextcloud · Oct 3, 2023 · 8f30f97 · 8f30f97
2 parents fdb7fe2 + 217a2a1
commit 8f30f97
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 7 deletions.
diff --git a/apps/files_sharing/src/views/SharingDetailsTab.vue b/apps/files_sharing/src/views/SharingDetailsTab.vue
@@ -197,6 +197,9 @@
 				</NcButton>
 				<NcButton type="primary" @click="saveShare">
 					{{ shareButtonText }}
+					<template v-if="creating" #icon>
+						<NcLoadingIcon />
+					</template>
 				</NcButton>
 			</div>
 		</div>
@@ -210,6 +213,7 @@ import NcAvatar from '@nextcloud/vue/dist/Components/NcAvatar.js'
 import NcDatetimePicker from '@nextcloud/vue/dist/Components/NcDatetimePicker.js'
 import NcDateTimePickerNative from '@nextcloud/vue/dist/Components/NcDateTimePickerNative.js'
 import NcCheckboxRadioSwitch from '@nextcloud/vue/dist/Components/NcCheckboxRadioSwitch.js'
+import NcLoadingIcon from '@nextcloud/vue/dist/Components/NcLoadingIcon.js'
 import CircleIcon from 'vue-material-design-icons/CircleOutline.vue'
 import CloseIcon from 'vue-material-design-icons/Close.vue'
 import EditIcon from 'vue-material-design-icons/Pencil.vue'
@@ -244,6 +248,7 @@ export default {
 		NcDatetimePicker,
 		NcDateTimePickerNative,
 		NcCheckboxRadioSwitch,
+		NcLoadingIcon,
 		CloseIcon,
 		CircleIcon,
 		EditIcon,
@@ -282,6 +287,7 @@ export default {
 			bundledPermissions: BUNDLED_PERMISSIONS,
 			isFirstComponentLoad: true,
 			test: false,
+			creating: false,
 		}
 	},
 
@@ -804,7 +810,9 @@ export default {
 					incomingShare.password = this.share.password
 				}
 
+				this.creating = true
 				const share = await this.addShare(incomingShare, this.fileInfo)
+				this.creating = false
 				this.share = share
 				this.$emit('add:share', this.share)
 			} else {

diff --git a/dist/10-10.js b/dist/10-10.js
diff --git a/dist/520-520.js.LICENSE.txt → dist/10-10.js.LICENSE.txt b/dist/520-520.js.LICENSE.txt → dist/10-10.js.LICENSE.txt
diff --git a/dist/10-10.js.map b/dist/10-10.js.map
diff --git a/dist/520-520.js b/dist/520-520.js
diff --git a/dist/520-520.js.map b/dist/520-520.js.map
diff --git a/dist/files_sharing-files_sharing_tab.js b/dist/files_sharing-files_sharing_tab.js
diff --git a/dist/files_sharing-files_sharing_tab.js.map b/dist/files_sharing-files_sharing_tab.js.map