-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix "Unknown path" error when source user files
folder has not been initialized
#46124
Open
Pytal
wants to merge
2
commits into
master
Choose a base branch
from
fix/ownership-transfer-source-user-files
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpick, but looks good otherwise 👍
Pytal
force-pushed
the
fix/ownership-transfer-source-user-files
branch
from
June 27, 2024 18:49
9492c94
to
92432a2
Compare
Merged
juliushaertl
approved these changes
Aug 6, 2024
Merged
Merged
Pytal
force-pushed
the
fix/ownership-transfer-source-user-files
branch
from
August 26, 2024 22:38
b2b5142
to
812280c
Compare
Pytal
requested review from
a team and
yemkareems
and removed request for
a team
August 26, 2024 22:38
AndyScherzinger
force-pushed
the
fix/ownership-transfer-source-user-files
branch
from
September 3, 2024 10:25
812280c
to
2b2cc10
Compare
sorbaugh
approved these changes
Sep 3, 2024
… been initialized Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Pytal
force-pushed
the
fix/ownership-transfer-source-user-files
branch
from
September 3, 2024 17:22
2b2cc10
to
918a16b
Compare
Pytal
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Sep 3, 2024
/backport to stable30 |
/backport to stable29 |
/backport to stable28 |
CI failure unrelated |
"Recent push is still being processed, and will show up in a bit" :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Calling
transfer()
with a source user who has not yet logged in will throw an "Unknown path" error. To fix this we initialize the source user filesystem like we do with the destination user.Checklist