feat(sidebar): Show node owner in metadata subline #46691
Merged
+94
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fenn-CS
force-pushed
the
fix-show-original-owner
branch
from
6aafa87
to
f0b68d7
Compare
Fenn-CS
commented
Jul 25, 2024
Show original file owner in side barNow that some logic to show the owner is in place with a simple "draft" to show this information with the userbubble near other folder metada can @nextcloud/designers chime in?
|
Fenn-CS
added
enhancement
2. developing
|
Nice! Good idea using the user bubble component. I would suggest we include only the username in the user bubble, and to separate the different metadata we could use a middle dot Also the user bubble component should be center aligned with the rest of the text :) |
Fenn-CS
force-pushed
the
fix-show-original-owner
branch
from
f0b68d7
to
6a3886f
Compare
Fenn-CS
force-pushed
the
fix-show-original-owner
branch
2 times, most recently
from
9c1c432
to
1a55a34
Compare
Fenn-CS
changed the title
sorbaugh
approved these changes
Jul 31, 2024
Fenn-CS
force-pushed
the
fix-show-original-owner
branch
from
1a55a34
to
23fed46
Compare
Fenn-CS
force-pushed
the
fix-show-original-owner
branch
from
23fed46
to
a512bfd
Compare
susnux
reviewed
Sep 3, 2024
Fenn-CS
force-pushed
the
fix-show-original-owner
branch
from
a512bfd
to
bcd9cd8
Compare
Fenn-CS
force-pushed
the
fix-show-original-owner
branch
from
bcd9cd8
to
1a0b447
Compare
Fenn-CS
force-pushed
the
fix-show-original-owner
branch
2 times, most recently
from
50600f2
to
c10edef
Compare
artonge
reviewed
Sep 18, 2024
Fenn-CS
force-pushed
the
fix-show-original-owner
branch
from
c10edef
to
5de2e05
Compare
artonge
reviewed
Sep 19, 2024
Fenn-CS
force-pushed
the
fix-show-original-owner
branch
2 times, most recently
from
cb22b2d
to
908165a
Compare
sorbaugh
approved these changes
Sep 23, 2024
Fenn-CS
force-pushed
the
fix-show-original-owner
branch
2 times, most recently
from
51d2ce5
to
0a5898f
Compare
Fenn-CS
force-pushed
the
fix-show-original-owner
branch
from
0a5898f
to
4ee748f
Compare
susnux
reviewed
Oct 7, 2024
susnux
approved these changes
Oct 7, 2024
Resolves: #46178 Signed-off-by: fenn-cs <[email protected]>
Fenn-CS
force-pushed
the
fix-show-original-owner
branch
from
4ee748f
to
faa29a0
Compare
|
/compile |
|
/backport to stable30 |
Signed-off-by: nextcloud-command <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Show user bubble to indicate owner of file in sidebar overview (this should not change irrespective of share status)...
Resolves: #46178
Screenshots
TODO