fix(files_sharing): show proper share not found error message

[skjnldsv]

When trying to access a share token which doesn't exists or is expired
https://dev.domain.com/s/oiqAxS8tzdPNBzN

Before	After

Not the best, but a bit cleaner as far as error page goes

@nextcloud/designers

[Fenn-CS]

🐘

[szaimen]

Looks nice from the screenshots :)

[susnux]

We can also consider something like this:

diff --git a/core/templates/404.php b/core/templates/404.php
index d2dc10f9aa8..1f58da3ef9d 100644
--- a/core/templates/404.php
+++ b/core/templates/404.php
@@ -21,9 +21,13 @@ if (!isset($_)) {//standalone  page is not supported anymore - redirect to /
 	<?php print_unescaped($_['content']) ?>
 <?php else: ?>
 	<div class="body-login-container update">
-		<div class="icon-big icon-search"></div>
-		<h2><?php p($l->t('Page not found')); ?></h2>
-		<p class="infogroup"><?php p($l->t('The page could not be found on the server or you may not be allowed to view it.')); ?></p>
+		<div class="icon-big <?php p($_['iconClass'] ?? 'icon-search'); ?>"></div>
+		<h2>
+			<?php p($_['heading'] ?? $l->t('Page not found')); ?>
+		</h2>
+		<p class="infogroup">
+			<?php p($_['message'] ?? $l->t('The page could not be found on the server or you may not be allowed to view it.')); ?>
+		</p>
 		<p><a class="button primary" href="<?php p(\OC::$server->getURLGenerator()->linkTo('', 'index.php')) ?>">
 			<?php p($l->t('Back to %s', [$theme->getName()])); ?>
 		</a></p>
diff --git a/lib/public/AppFramework/Http/NotFoundResponse.php b/lib/public/AppFramework/Http/NotFoundResponse.php
index 9ebefe69be1..fa936a82976 100644
--- a/lib/public/AppFramework/Http/NotFoundResponse.php
+++ b/lib/public/AppFramework/Http/NotFoundResponse.php
@@ -12,18 +12,17 @@ use OCP\AppFramework\Http;
 /**
  * A generic 404 response showing an 404 error page as well to the end-user
  * @since 8.1.0
- * @template S of int
  * @template H of array<string, mixed>
- * @template-extends TemplateResponse<int, array<string, mixed>>
+ * @template-extends TemplateResponse<Http::STATUS_NOT_FOUND, array<string, mixed>>
  */
 class NotFoundResponse extends TemplateResponse {
 	/**
-	 * @param S $status
+	 * @param array{message?: string, headline?: string, iconClass?: string} $params
 	 * @param H $headers
 	 * @since 8.1.0
 	 */
-	public function __construct(int $status = Http::STATUS_NOT_FOUND, array $headers = []) {
-		parent::__construct('core', '404', [], 'guest', $status, $headers);
+	public function __construct(array $params = [], array $headers = []) {
+		parent::__construct('core', '404', $params, 'guest', Http::STATUS_NOT_FOUND, $headers);
 
 		$this->setContentSecurityPolicy(new ContentSecurityPolicy());
 	}

Meaning we could make the response customizable (heading, message and icon).

[skjnldsv]

We can also consider something like this:

Meaning we could make the response customizable (heading, message and icon).

I also started doing this. But wanted to avoid changing any existing code during freeze 🧊

[nimishavijay]

Nice! Indeed this is better :)

I would go for this person-cancel symbol instead.

Also, the subline is missing a full stop at the end :)

[AndyScherzinger]

LGTM 💙