fix(ProvisioningAPI): set typed config values by via API

[blizzz]

• Resolves: [Bug]: Unable to update background execution mode: conflict between new type (mixed) and old type (string) #45083

Summary

On Javascript side we have one method at hand to set an app config value: CP.AppConfig.setValue(). As value it takes a string and sends this over the Provisioning API to the server.

Meanwhile we have typed configuration entries. All existing entries are default to the IAppConfig::VALUE_MIXED type. New entries however are bound to their type. For instance a new boolean value cannot be set via JavaScript anymore.

This fix solves this on API level. All clients may still send strings, and the Provisioning API's Controller tries to cast the provided value into the target type.

I see this sort of critical myself as there is not good validation of the casted value. On the other hand I do not think it can do much harm, only fail in a different way. Still, an alternative would be to have also dedicated setter on the JS side, and endpoints for each acceptable type. Personally I don't have the time for this approach today anymore. I am totally fine to discard this PR in favor of a better replacement :)

Todo

• check were backports are necessary

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[susnux]

I think this is a ok solution for now. We probably need a better way to fix this in the future as you said.

[ariep]

Hi, I'm impacted by #45083 so I'm eagerly watching this PR. I get the same type conflict error when I do a php occ config:import ... and the json file contains

[...]
        "apps":{                                                                                                                                                                              
            "core":{                                                                                                                                                                          
                "backgroundjobs_mode": "webcron"
[...]

@kesselb recommended that I mention this particular case here because it might not be solved by this PR in its current form. Is there any chance you could fix that case as well?

[blizzz]

I get the same type conflict error when I do a php occ config:import ...

Hm, on occ there is should be another entrypoint somewhere.

[blizzz]

rebased, adjusted and added tests (no prod code change since)

[blizzz]

/backport to stable30

[blizzz]

/backport to stable29

[blizzz]

I get the same type conflict error when I do a php occ config:import ...

Hm, on occ there is should be another entrypoint somewhere.

Not scope of this PR, requires a follow up.

[nickvergessen]

Please no backports. this is a breaking change 👎
Talk integration tests are glowing red with {"Exception":"OCP\\Exceptions\\AppConfigUnknownKeyException","Message":"unknown config key"

[nickvergessen]

Fix in #47409