feat(files_sharing): confirm share deletion

[printminion-co]

Summary

Currently, it is possible to remove a share without confirmation.

This is problematic if the share link has already been shared with users. The share link is deleted permanently, and it cannot be restored.

To prevent accidental share deletion, this feature adds a confirmation dialog (see screenshot).

New confirmation dialog on share delete

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[AndyScherzinger]

looping in @jancborchardt since we usually (or never?) have confirmation steps on actions also not no destructive ones.

[printminion-co]

looping in @jancborchardt since we usually (or never?) have confirmation steps on actions also not no destructive ones.

One can see confirmation dialog on deletion of 5+ files/folders.

[jancborchardt]

Very nice improvement! Just the wording should be adjusted:

• The title needs to be "Delete share" like the action that wqs just clicked, and like the primary confirmation button.
• The content needs to include the name of the share and who it is unshared from, like: "Pictures will be unshared from Andy Scherzinger."
  • The name of the person should use the avatarbubble component.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[jancborchardt]

@printminion-co do you need any help besides the feedback @skjnldsv and I gave? :) No pressure from our side, just asking if there is any blocker.

[skjnldsv]

@printminion-co if you are lacking the time, I can take over next week

[printminion-co]

@printminion-co do you need any help besides the feedback @skjnldsv and I gave? :) No pressure from our side, just asking if there is any blocker.

I was in vacation ;)
...I've applied proposed code changes

[printminion-co]

• The content needs to include the name of the share and who it is unshared from, like: "Pictures will be unshared from Andy Scherzinger."

Added File/folder name (without user reference) with similar text in deletion confirmation

CC @AndyScherzinger

[AndyScherzinger]

Added File/folder name (without user reference) with similar text in deletion confirmation

Looks good to me, any confirmation dialog is somewhat better than none so if technically fine I vote to merge it. Cc @sorbaugh