[WIP] Make router interface reactive while being framework agnostic #47136
+78
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it is only reactive when used within the files app, because the files app can access the vue router directly, problem is when other apps use it, then it is not reactive anymore as they have a different Vue. Also if you do not use Vue but vanilla JS or something else, the router params and query would not be reactive. Problem that this is solving: React to route changes only, watching current view and query will trigger on different time frames causing invalid states. e.g. changing the view from A to B and the query from `/foo` to `/` will cause: 1. View change 2. query change But after 1 the query is invalid and cause issues. So this changes will allow listening the route change which is combined 1 & 2 -> valid state. Signed-off-by: Ferdinand Thiessen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is only reactive when used within the files app, because the files app can access the vue router directly, problem is when other apps use it, then it is not reactive anymore as they have a different Vue.
Also if you do not use Vue but vanilla JS or something else, the router params and query would not be reactive.
Problem that this is solving: React to route changes only, watching current view and query will trigger on different time frames causing invalid states.
e.g. changing the view from A to B and the query from
/footo/will cause:But after 1 the query is invalid and cause issues.
So this changes will allow listening the route change which is combined 1 & 2 -> valid state.
Summary
TODO
Checklist