perf: improve cleanup of tags/comments #47182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
Altahrim,
yemkareems and
provokateurin
and removed request for
a team
Merged
delete entire chunk at once instead of one-by-one Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
orphan-cleanup-chunk-perf
branch
from
d3defd2
to
0f9ea19
Compare
|
/backport to stable30 |
sorbaugh
approved these changes
Aug 16, 2024
| $deletedInLastChunk = count($chunk); | ||
|
|
||
| $deleteQuery->setParameter('objectid', $chunk, IQueryBuilder::PARAM_INT_ARRAY); | ||
| $deletedEntries += $deleteQuery->executeStatement(); |
There was a problem hiding this comment.
Should we wrap with a transaction to make it faster?
There was a problem hiding this comment.
I expect that that will lead to issues around transaction sizes and deadlocks
come-nc
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete entire chunk at once instead of one-by-one