Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve wording of occ:upgrade command when no upgrade is required #49914

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix: improve wording of occ:upgrade command when no upgrade is required #49914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion core/Command/Upgrade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
use OCP\EventDispatcher\Event;
use OCP\EventDispatcher\IEventDispatcher;
use OCP\IConfig;
use OCP\IURLGenerator;
use OCP\Util;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Helper\ProgressBar;
Expand All @@ -36,6 +37,7 @@ class Upgrade extends Command {

public function __construct(
private IConfig $config,
private IURLGenerator $urlGenerator,
) {
parent::__construct();
}
Expand Down Expand Up @@ -205,7 +207,11 @@ function ($success) use ($output, $self) {
. 'config.php and call this script again.</comment>', true);
return self::ERROR_MAINTENANCE_MODE;
} else {
$output->writeln('<info>Nextcloud is already latest version</info>');
$output->writeln('<info>No upgrade required.</info>');
$output->writeln('');
$output->writeln('Note: This command triggers the upgrade actions associated with a new version. The new version\'s updated source files must be deployed in advance.');
$doc = $this->urlGenerator->linkToDocs('admin-update');
$output->writeln('See the upgrade documentation: ' . $doc . ' for more information.');
return self::ERROR_UP_TO_DATE;
}
}
Expand Down
Loading