Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Chat): consider shared objects when marking unread #13214

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix(Chat): consider shared objects when marking unread #13214

merged 1 commit into from
Sep 10, 2024

Conversation

sanskar-soni-9
Copy link
Contributor

@sanskar-soni-9 sanskar-soni-9 commented Sep 5, 2024 •
edited
Loading

☑️ Resolves

The PR addresses the issue where the chat unread message counter is incorrect when there is a message with VERB_OBJECT_SHARED in unreads. The solution includes shared objects in unread count.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@Antreesy Antreesy added 3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥 labels Sep 5, 2024
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Sep 5, 2024
@SystemKeeper
Copy link
Contributor

Is there a chance we could cover that by a test? 🤔

@sanskar-soni-9 sanskar-soni-9 force-pushed the fix/unread-count-for-chat-with-shared-objects branch from 813026d to 91d0e2f Compare September 8, 2024 02:28
@sanskar-soni-9 sanskar-soni-9 changed the title fix(Chat): include shared objects in unread count fix(Chat): consider shared objects when marking unread Sep 8, 2024
@sanskar-soni-9 sanskar-soni-9 force-pushed the fix/unread-count-for-chat-with-shared-objects branch from 91d0e2f to d69ed42 Compare September 8, 2024 02:32
@sanskar-soni-9 sanskar-soni-9 force-pushed the fix/unread-count-for-chat-with-shared-objects branch from d69ed42 to a6af2c8 Compare September 8, 2024 02:45
@nickvergessen
Copy link
Member

/backport to stable30

@nickvergessen nickvergessen merged commit ae83af9 into main Sep 10, 2024
68 checks passed
@nickvergessen nickvergessen deleted the fix/unread-count-for-chat-with-shared-objects branch September 10, 2024 15:09
@backportbot backportbot bot mentioned this pull request Sep 10, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@skalidindi53 skalidindi53 skalidindi53 approved these changes

Assignees
No one assigned
Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥 feedback-requested
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.

Mark as unread shows 2 unread messages when last message is a file
5 participants
@sanskar-soni-9 @SystemKeeper @nickvergessen @skalidindi53 @Antreesy