feat(calls): Allow to enforce a maximum call length #13456
Conversation
nickvergessen
added
3. to review
enhancement
feature: settings ⚙️
nickvergessen
force-pushed
the
feat/13445/hard-end-call-limit
branch
from
d366ba2
to
59fe55b
Compare
nickvergessen
force-pushed
the
feat/13445/hard-end-call-limit
branch
from
59fe55b
to
289d82e
Compare
docs/settings.md
Outdated
| @@ -82,6 +82,7 @@ Legend: | |||
| | `bridge_bot_password` | string | | No | | Automatically generated password of the matterbridge bot user profile | | |||
| | `default_attachment_folder` | string | `/Talk` | No | | Specify default attachment folder location | | |||
| | `start_calls` | int | `0` | Yes | 🖌️ | Who can start a call, see [constants list](constants.md#start-call) | | |||
| | `max_call_duration` | int | `0` | No | | Maximum duration of a call in seconds, 0 for unlimited | | |||
There was a problem hiding this comment.
Should it be mentioned that federated rooms are not supported?
There was a problem hiding this comment.
They are on the host? But yes we can add it.
|
This value is not available in capabilities => clients and users don't know about the limit. The call just suddenly stops. Shall we add it to capabilities to be able to inform users about it? |
| continue; | ||
| } | ||
|
|
||
| $this->participantService->endCallForEveryone($room, null); |
There was a problem hiding this comment.
To think about it in the future: this would be nice to be able to set the reason. So users know why the call has been ended.
|
Tested with 300 seconds. The call was ended after 407 seconds regardless of the second participant joining time. Both 1-1 and group. Using the default cron. |
Sounds like a good UX follow up. But out of scope for the current requirements :)
Well if cron is not running there is little we can do. If you do a mobile app only call nothing is pinging the server, so we have to rely on the server cron. Planned requirement is 12h, so the ~5 min worst case overlay is "accepted risk". |
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
feat/13445/hard-end-call-limit
branch
from
289d82e
to
829fddd
Compare
There was a problem hiding this comment.
Works, but some things to concern:
- Users have no sign that the call time is limited
- Clients have no possibility to inform users about the limit
- A call ends suddenly like it was ended by a participant. User "Alice" may be confused why there is "Alice ended the call" when nobody ended the call
- Duration is in seconds, but with the default cron it might have 300 seconds error. Might be unclear for users
It's a bit confusing:
Do we need 1 second precision with ~300 sec error and thousands of seconds values? Maybe then make it in minutes and if we add a UI make it 5 min step? Or at least note it in the docs. |
Makes CI testing easier if we add it.
We will not :) |
☑️ Resolves
🛠️ API Checklist
Tested with:
🏁 Checklist
docs/has been updated or is not required