enh: remove usages of NAV_ENTRY_MODE_RECIPIENTS

Signed-off-by: Cleopatra Enjeck M. <[email protected]>
nextcloud · Dec 30, 2024 · e0a2cd8 · e0a2cd8
1 parent f86c8c3
commit e0a2cd8
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/src/modules/modals/CreateContext.vue b/src/modules/modals/CreateContext.vue
@@ -171,7 +171,7 @@ export default {
 					isUser: true,
 					key: 'user-' + getCurrentUser().uid,
 				})
-			const displayMode = this.showInNavigation ? 'NAV_ENTRY_MODE_RECIPIENTS' : 'NAV_ENTRY_MODE_HIDDEN'
+			const displayMode = this.showInNavigation ? 'NAV_ENTRY_MODE_ALL' : 'NAV_ENTRY_MODE_HIDDEN'
 			const res = await this.$store.dispatch('insertNewContext', { data, previousReceivers: [], receivers: this.receivers, displayMode: NAV_ENTRY_MODE[displayMode] })
 			if (res) {
 				return res.id

diff --git a/src/modules/modals/EditContext.vue b/src/modules/modals/EditContext.vue
@@ -185,7 +185,7 @@ export default {
 						isUser: true,
 						key: 'user-' + getCurrentUser().uid,
 					})
-				const displayMode = this.showInNavigationDefault ? 'NAV_ENTRY_MODE_RECIPIENTS' : 'NAV_ENTRY_MODE_HIDDEN'
+				const displayMode = this.showInNavigationDefault ? 'NAV_ENTRY_MODE_ALL' : 'NAV_ENTRY_MODE_HIDDEN'
 				const res = await this.$store.dispatch('updateContext', { id: this.contextId, data, previousReceivers: Object.values(context.sharing), receivers: this.receivers, displayMode: NAV_ENTRY_MODE[displayMode] })
 				if (res) {
 					showSuccess(t('tables', 'Updated application "{contextTitle}".', { contextTitle: this.title }))

diff --git a/src/shared/constants.js b/src/shared/constants.js
@@ -28,6 +28,6 @@ export const TYPE_USERGROUP = 'usergroup'
 
 export const NAV_ENTRY_MODE = {
 	NAV_ENTRY_MODE_HIDDEN: 0, // no nav bar entry
-	NAV_ENTRY_MODE_RECIPIENTS: 1, // nav bar entry for share recipients, but not the owner
+	// NAV_ENTRY_MODE_RECIPIENTS: 1, // nav bar entry for share recipients, but not the owner. Currently unused.
 	NAV_ENTRY_MODE_ALL: 2, // nav bar entry for everybody
 }
diff --git a/src/store/store.js b/src/store/store.js
@@ -10,7 +10,7 @@ import { showError } from '@nextcloud/dialogs'
 import '@nextcloud/dialogs/style.css'
 import data from './data.js'
 import displayError from '../shared/utils/displayError.js'
-import { NODE_TYPE_TABLE, NODE_TYPE_VIEW, NAV_ENTRY_MODE } from '../shared/constants.js'
+import { NODE_TYPE_TABLE, NODE_TYPE_VIEW } from '../shared/constants.js'
 import { getCurrentUser } from '@nextcloud/auth'
 
 Vue.use(Vuex)
@@ -364,9 +364,8 @@ export default new Vuex.Store({
 						if (createdShare?.data && createdShare?.data?.id) {
 							const shareId = createdShare.data.id
 							await dispatch('updateDisplayMode', { shareId, displayMode, target: 'default' })
-							// since we switch between NAV_ENTRY_MODE_HIDDEN and NAV_ENTRY_MODE_RECIPIENTS, we need to handle owner separately
 							if (receiver.id === getCurrentUser().uid) {
-								await dispatch('updateDisplayMode', { shareId, displayMode: displayMode === NAV_ENTRY_MODE.NAV_ENTRY_MODE_HIDDEN ? NAV_ENTRY_MODE.NAV_ENTRY_MODE_HIDDEN : NAV_ENTRY_MODE.NAV_ENTRY_MODE_ALL, target: 'self' })
+								await dispatch('updateDisplayMode', { shareId, displayMode, target: 'self' })
 							}
 						}
 					}