-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
share with teams #1465
share with teams #1465
Conversation
8a288e5
to
a6da886
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the backend bits only so far.
Thanks Arthur @blizzz 🙏 - those are really helpful! |
93927cb
to
a36c56e
Compare
7803db6
to
34d53d6
Compare
Thank you @enjeck! That's a really good points, I didn't think about that actually. I think we can hide those shares when circles disabled, that would be better and more appropriate for this case. Let me know if we expect it different like completely remove those shares @juliusknorr @blizzz , thank you! |
Yes, would agree with that. I think we do it the same way in the files app 👍 |
34d53d6
to
0c456a5
Compare
0c456a5
to
1f12051
Compare
To confirm, in addition to hiding the shares from the sidebar, the tables are not shared with the users in a team? |
Yes @enjeck, we check from BE so when getting all tables of a user will exclude those circle's shares |
1f12051
to
68c2920
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backendwise looks OK (only nitpicks, not blocking), did not do functional tests so far.
7d0a65b
to
ad53267
Compare
Signed-off-by: Hoang Pham <[email protected]>
ad53267
to
5dacb82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works
Fixes #142