fix: Update menu switch CSS selectors #1477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cleopatra Enjeck M. <[email protected]>
juliusknorr
reviewed
Nov 27, 2024
| @@ -82,20 +82,20 @@ export default { | |||
| this.$store.commit('setActiveTableId', parseInt(currentRoute.params.tableId)) | |||
| this.setPageTitle(this.$store.getters.activeTable.title) | |||
| if (!currentRoute.path.includes('/row/')) { | |||
| this.switchActiveMenuEntry(document.querySelector('header .header-left .app-menu a[title="Tables"]')) | |||
| this.switchActiveMenuEntry(document.querySelector('header .header-start .app-menu a[title="Tables"]')) | |||
There was a problem hiding this comment.
I think this change also only happened on master/stable30 not older versions so we might need a fallback.
Yes, definitely a good idea. The app menu in server has some API to update or set a counter already, maybe we can think about extending that to set the active entry: https://github.com/nextcloud/server/blob/c5baf3d7ef2715def79ff7734d505c56bb20012c/core/src/components/MainMenu.js#L29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once again, the CSS styling changed and we have to update this. Otherwise, we have the error message in the console:
"TypeError: Cannot read properties of null (reading 'classList')"Would be nice to someday have a better solution for this, since we've had to update these styles several times already