fix(Views): allow to sort for meta columns #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
commented
Jan 6, 2025
lib/Service/ViewService.php
Outdated
| $columnsArray = $view->getColumnsArray(); | ||
| if (isset($sortRule['columnId']) && $columnsArray && in_array($sortRule['columnId'], $columnsArray, true)) { | ||
| if (isset($sortRule['columnId']) | ||
| && $sortRule['columnId'] >= 0 // meta columns can be exposed |
There was a problem hiding this comment.
I would adapt to negated isValidMetaTypeId() check from #1526 once that's in.
- also fixes a return value that otherwise may render shared views ontentless Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
fix/1524/sort-views-hide-not-null
branch
from
01cfe8d to
faa22c4
Compare
|
Rebased, adjusted, and fixed a logic i had in, and sorting for share recipients works now. |
|
/backport to stable0.8 |
juliusknorr
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now however, for owners the sorting is working
,but for share recipients it is not (but the content is at least visible).Not sure this is the best approach, and the sorting needs frontend changes as well. Hoping for your feedback @enjeckaddresses #1524