Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP. Fix failing login etc #4700

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP. Fix failing login etc #4700

wants to merge 1 commit into from

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Feb 7, 2025

WIP!

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
B A

🚧 TODO

  • comment in openHelperFactory again...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • πŸ”– Capability is checked or not needed
  • πŸ”™ Backport requests are created or not needed: /backport to stable-xx.x
  • πŸ“… Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi added the 2. developing Work in progress label Feb 7, 2025
@mahibi mahibi self-assigned this Feb 7, 2025
@mahibi mahibi marked this pull request as draft February 7, 2025 12:37
Copy link
Contributor

github-actions bot commented Feb 7, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4700-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Codacy

Lint

TypemasterPR
Warnings104105
Errors3636

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

Lint increased!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant