Merge pull request #1800 from nextcloud/simplify-capability-check

Simplify capability checking
nextcloud · Sep 13, 2024 · 995395e · 995395e
2 parents cd7cb2f + bcbf52f
commit 995395e
Showing 1 changed file with 7 additions and 17 deletions.
diff --git a/NextcloudTalk/NCDatabaseManager.m b/NextcloudTalk/NCDatabaseManager.m
@@ -506,28 +506,18 @@ - (void)setFederatedCapabilities:(NSDictionary *)federatedCapabilitiesDict forAc
 
 - (BOOL)roomHasTalkCapability:(NSString *)capability forRoom:(NCRoom *)room
 {
-    if (room.isFederated) {
-        FederatedCapabilities *federatedCapabilities = [self federatedCapabilitiesForAccountId:room.accountId remoteServer:room.remoteServer roomToken:room.token];
+    if (!room.isFederated) {
+        return [self serverHasTalkCapability:capability forAccountId:room.accountId];
+    }
 
-        if (federatedCapabilities) {
-            NSArray *talkFeatures = [federatedCapabilities.talkCapabilities valueForKey:@"self"];
-            if ([talkFeatures containsObject:capability]) {
-                return YES;
-            }
-        }
+    FederatedCapabilities *federatedCapabilities = [self federatedCapabilitiesForAccountId:room.accountId remoteServer:room.remoteServer roomToken:room.token];
 
+    if (!federatedCapabilities) {
         return NO;
     }
 
-    ServerCapabilities *serverCapabilities = [self serverCapabilitiesForAccountId:room.accountId];
-    if (serverCapabilities) {
-        NSArray *talkFeatures = [serverCapabilities.talkCapabilities valueForKey:@"self"];
-        if ([talkFeatures containsObject:capability]) {
-            return YES;
-        }
-    }
-
-    return NO;
+    NSArray *talkFeatures = [federatedCapabilities.talkCapabilities valueForKey:@"self"];
+    return [talkFeatures containsObject:capability];
 }
 
 - (TalkCapabilities * __nullable)roomTalkCapabilitiesForRoom:(NCRoom *)room