Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that we reset the
currentRoom
when weforceReconnect
, which is fine for "normal" forced reconnects:talk-ios/NextcloudTalk/NCExternalSignalingController.m
Lines 176 to 183 in a09c4a0
In case our publisher peer fails, we want to rejoin the call, for that, we call
forceReconnect
onNCExternalSignalingController
fromNCCallController
:talk-ios/NextcloudTalk/NCCallController.m
Lines 321 to 323 in a09c4a0
But for the re-join to work correctly, the
NCExternalSignalingController
needs to be aware, that we were in a room already:talk-ios/NextcloudTalk/NCExternalSignalingController.m
Lines 348 to 352 in a09c4a0
And this check failed since we reseted
currentRoom
on aforceReconnect
. This results in showing the waiting message "Connecting to the call …" but nothing is ever happening.How to test